From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result Date: Tue, 14 Mar 2023 09:22:01 +0100 Message-ID: <87a60fvj2u.fsf@gmail.com> References: <167832056288.21107.13816783611653909117@vcs2.savannah.gnu.org> <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> <87ilfansyb.fsf@gmail.com> <875yb72kb9.fsf@athena.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 14 09:22:54 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbzvp-0003Fj-Q8 for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Mar 2023 09:22:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbzv7-0007a2-Td; Tue, 14 Mar 2023 04:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbzv6-0007Zo-Cw for emacs-devel@gnu.org; Tue, 14 Mar 2023 04:22:08 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbzv3-0000gX-OK for emacs-devel@gnu.org; Tue, 14 Mar 2023 04:22:07 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id o7so4089735wrg.5 for ; Tue, 14 Mar 2023 01:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678782123; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+JtwQ57yF9niwPxrX3vfDsippl7PPqvDHptsPAIjh3A=; b=KMiIthT2TaUrD6WRYsy25WTNQWoC8bg9NDjgxTVk4ZTkUSAg7zIdG5poxQ6JKLd3ey WkjoMWfRlYBdYG8CT10rvd7mJGJbL7S/Bml8KuO+BeGjEXKaXOF13VCHHxexUXBAGQe1 ApUwkYZk4gmAeMrBL3pcc2kBYcAMwEGO1arcyfB5awUFEOfPGV7OIh1lwnkYteWIY9/y BdUu64x7hWXDNTahbA4spGcS6L4xYLw2AI6Qn90ZMKINjZEDpyk6KlrIE8prFhrRo7yz WQFCnD9tKkzriuCHHG9Nk88SU4SAAXjcGA/fz0kWRU/ZXs1V/QDEANLYLQ/64cvF1iW5 E3qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678782123; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+JtwQ57yF9niwPxrX3vfDsippl7PPqvDHptsPAIjh3A=; b=DvaqhedAwUfZyDsUPg039NfxYkK5CmqI3BoQZM5hccERR7TxBtX4g4KQTDZva+8Rkj mthgqGyCk5sPGf59AXdeKV83024Xi9qyKVn1e5qGoIZIwYX0uJjreRnRr6DbYDZP9NwJ Wdhz4Teo+XlBFgRH8oQQKAx/aFdYZq/yLRYKDN6yqBwLMJSKHywz5hwhozR2sFjZF9rV nl6R1SfzWHHQylwKlAX61LkyiFZ7csZOVKANrb262XtqLDxQQC3Bq01XQEp8JvO5wy2O BSY5pT1JMSXWb/2B87yikW1EG0ZytAT3mtZDTT5IM7S6i0VLkKnDcpwV7EU0YgpLUvKC htcw== X-Gm-Message-State: AO0yUKVEWeKjh37sS4aGfy1k3KhQmwcnGM5DYoZ6xKmDrwG6oqgP1Cdf rrbRZypCoHhdHx4uqFnzGdssRW481Kw= X-Google-Smtp-Source: AK7set90gYM0PPFp6bE/o3zil9WtGD58Xogp459eddR5fKCCKZCvqky4TXtFgIaz/TgTxZ1BOpwR5A== X-Received: by 2002:adf:f58d:0:b0:2cd:e089:398d with SMTP id f13-20020adff58d000000b002cde089398dmr11653912wro.5.1678782122671; Tue, 14 Mar 2023 01:22:02 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id p9-20020adfce09000000b002cdbb26bb48sm1474041wrn.33.2023.03.14.01.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 01:22:01 -0700 (PDT) In-Reply-To: <875yb72kb9.fsf@athena.silentflame.com> (Sean Whitton's message of "Sat, 11 Mar 2023 11:51:22 -0700") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304426 Archived-At: >>>>> On Sat, 11 Mar 2023 11:51:22 -0700, Sean Whitton said: Sean> Hello, Sean> On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote: >> diff --git a/lisp/server.el b/lisp/server.el >> index 89aedc72d52..1bbfdced5b0 100644 >> --- a/lisp/server.el >> +++ b/lisp/server.el >> @@ -1930,7 +1930,7 @@ server-unload-function >> nil) >> >> (define-error 'server-return-invalid-read-syntax >> - "Emacs server returned unreadable result of evaluation" >> + "Result of evaluation by Emacs server is unreadable" >> 'invalid-read-syntax) Sean> I find this less good as a user-visible error message. OK >> (defun server-eval-at (server form) >> @@ -1941,10 +1941,10 @@ server-eval-at >> >> This function signals `error' if it could not contact the server. >> >> -This function signals `server-return-invalid-read-syntax' if it >> -couldn't read the result of evaluation printed by the server. >> -This will occur whenever the result of evaluating FORM is something >> -not readably printable." >> +This function signals `server-return-invalid-read-syntax' if >> +`read' fails on the result returned by the server. >> +This will occur whenever the result of evaluating FORM is >> +something that cannot be printed readably." >> (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) >> (server-file (expand-file-name server server-dir)) >> (coding-system-for-read 'binary) Sean> Nice, this makes the wording seem less like a tautology, please install! Done as b9a70865d2c Robert --