From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result Date: Sat, 11 Mar 2023 11:51:22 -0700 Message-ID: <875yb72kb9.fsf@athena.silentflame.com> References: <167832056288.21107.13816783611653909117@vcs2.savannah.gnu.org> <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> <87ilfansyb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 11 19:51:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb4Jh-0002rJ-42 for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Mar 2023 19:51:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pb4JW-0008Hr-Bm; Sat, 11 Mar 2023 13:51:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb4JU-0008HM-D1 for emacs-devel@gnu.org; Sat, 11 Mar 2023 13:51:28 -0500 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb4JS-0006gd-DK for emacs-devel@gnu.org; Sat, 11 Mar 2023 13:51:27 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 045BD32008FE; Sat, 11 Mar 2023 13:51:23 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 11 Mar 2023 13:51:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1678560683; x= 1678647083; bh=XP/nj/GohMGX9qr7CHktmY45A0zPQ4P1XQU52y/ZUq0=; b=X WlCDtLBoA6rnEPt9K9eoopzvId0YowHjrGKn36fLsrtPxjrdZcVGTHCXhtBkGvkf nF+2PtELzZGCn5bI+uSj/t/qxEpNRXYKmpL581UCTjX3XGU3XHwX/sVgV7EZdwp1 0jKRvxNB04r7wGPloIZqL373bTiBMR3RcbKFqV6UBfnqwJ04+EYNF9e77Yn0BMwJ Vey/iix7XY/iy35V2COg5MHMsSvhBaE068se333ovlXGdqX0bIGjOvClVRAavt+1 lOCCNVU4cZ3JCRM1l9pQdkgcW1GSBFL9lZmxHU8XgCq+bLARUFoNCF5eEgSANukf EEGNrr/rrxPDILKTnVoAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678560683; x=1678647083; bh=XP/nj/GohMGX9 qr7CHktmY45A0zPQ4P1XQU52y/ZUq0=; b=FWEndlVDU9W/fKJY3ptiEsRvC4A71 mp6j1wbd4MDyZj5FdpW94MUygCGH0RM3jLWdVEpNfJbX6v8rrlz/0tB7ngH3cWJ9 CWvCvIjeOB8FFJW7xWOPNnfrndvHPgQM69DgmtzbWmUq2faXaVWVsCicfPCTXELa tDP16Y/CP/X8ei+0w0KDinvq3XyNOawNKBX4+IRhbNF7vo5nmmARgaDxYDPJYAYv EeUJR1c1htTjm+9DQNucQdPvIRtHbZlKxiwI3lIj481/jy96QdqoyAxOJw1CP0MV 1LzBN8VkLSLy2PtEbuQuSk77dwT4TvkIkjsFQsA5dhjKrESoPr/Qmyhzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvtddgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Mar 2023 13:51:23 -0500 (EST) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id 745D41B583F; Sat, 11 Mar 2023 18:51:22 +0000 (UTC) In-Reply-To: <87ilfansyb.fsf@gmail.com> (Robert Pluim's message of "Thu, 09 Mar 2023 11:02:20 +0100") Received-SPF: pass client-ip=64.147.123.19; envelope-from=spwhitton@spwhitton.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304334 Archived-At: Hello, On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote: > diff --git a/lisp/server.el b/lisp/server.el > index 89aedc72d52..1bbfdced5b0 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1930,7 +1930,7 @@ server-unload-function > nil) > > (define-error 'server-return-invalid-read-syntax > - "Emacs server returned unreadable result of evaluation" > + "Result of evaluation by Emacs server is unreadable" > 'invalid-read-syntax) I find this less good as a user-visible error message. > (defun server-eval-at (server form) > @@ -1941,10 +1941,10 @@ server-eval-at > > This function signals `error' if it could not contact the server. > > -This function signals `server-return-invalid-read-syntax' if it > -couldn't read the result of evaluation printed by the server. > -This will occur whenever the result of evaluating FORM is something > -not readably printable." > +This function signals `server-return-invalid-read-syntax' if > +`read' fails on the result returned by the server. > +This will occur whenever the result of evaluating FORM is > +something that cannot be printed readably." > (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) > (server-file (expand-file-name server server-dir)) > (coding-system-for-read 'binary) Nice, this makes the wording seem less like a tautology, please install! -- Sean Whitton