Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result

[Sean Whitton <spwhitton@spwhitton.name>]

Hello,

On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote:

> diff --git a/lisp/server.el b/lisp/server.el
> index 89aedc72d52..1bbfdced5b0 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1930,7 +1930,7 @@ server-unload-function
>    nil)
>
>  (define-error 'server-return-invalid-read-syntax
> -              "Emacs server returned unreadable result of evaluation"
> +              "Result of evaluation by Emacs server is unreadable"
>                'invalid-read-syntax)

I find this less good as a user-visible error message.

>  (defun server-eval-at (server form)
> @@ -1941,10 +1941,10 @@ server-eval-at
>
>  This function signals `error' if it could not contact the server.
>
> -This function signals `server-return-invalid-read-syntax' if it
> -couldn't read the result of evaluation printed by the server.
> -This will occur whenever the result of evaluating FORM is something
> -not readably printable."
> +This function signals `server-return-invalid-read-syntax' if
> +`read' fails on the result returned by the server.
> +This will occur whenever the result of evaluating FORM is
> +something that cannot be printed readably."
>    (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir))
>           (server-file (expand-file-name server server-dir))
>           (coding-system-for-read 'binary)

Nice, this makes the wording seem less like a tautology, please install!

-- 
Sean Whitton