Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result

Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result

[Robert Pluim]

>>>>> On Wed,  8 Mar 2023 19:09:23 -0500 (EST), Sean Whitton <spwhitton@spwhitton.name> said:

    Sean> branch: master
    Sean> commit da4f1fa550f753e76c611b313d4f00987daed5ad
    Sean> Author: Sean Whitton <spwhitton@spwhitton.name>
    Sean> Commit: Sean Whitton <spwhitton@spwhitton.name>

    Sean>     server-eval-at: Signal more specific condition on unreadable result
    
    Sean>     * lisp/server.el (server-return-invalid-read-syntax): New error
    Sean>     signal.
    Sean>     (server-eval-at): Re-signal invalid-read-syntax as
    Sean>     server-return-invalid-read-syntax (bug#61658).

Iʼd suggest the following on top:

diff --git a/lisp/server.el b/lisp/server.el
index 89aedc72d52..1bbfdced5b0 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1930,7 +1930,7 @@ server-unload-function
   nil)
 
 (define-error 'server-return-invalid-read-syntax
-              "Emacs server returned unreadable result of evaluation"
+              "Result of evaluation by Emacs server is unreadable"
               'invalid-read-syntax)
 
 (defun server-eval-at (server form)
@@ -1941,10 +1941,10 @@ server-eval-at
 
 This function signals `error' if it could not contact the server.
 
-This function signals `server-return-invalid-read-syntax' if it
-couldn't read the result of evaluation printed by the server.
-This will occur whenever the result of evaluating FORM is something
-not readably printable."
+This function signals `server-return-invalid-read-syntax' if
+`read' fails on the result returned by the server.
+This will occur whenever the result of evaluating FORM is
+something that cannot be printed readably."
   (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir))
          (server-file (expand-file-name server server-dir))
          (coding-system-for-read 'binary)

Robert
-- 

Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result

[Sean Whitton]

Hello,

On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote:

> diff --git a/lisp/server.el b/lisp/server.el
> index 89aedc72d52..1bbfdced5b0 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1930,7 +1930,7 @@ server-unload-function
>    nil)
>
>  (define-error 'server-return-invalid-read-syntax
> -              "Emacs server returned unreadable result of evaluation"
> +              "Result of evaluation by Emacs server is unreadable"
>                'invalid-read-syntax)

I find this less good as a user-visible error message.

>  (defun server-eval-at (server form)
> @@ -1941,10 +1941,10 @@ server-eval-at
>
>  This function signals `error' if it could not contact the server.
>
> -This function signals `server-return-invalid-read-syntax' if it
> -couldn't read the result of evaluation printed by the server.
> -This will occur whenever the result of evaluating FORM is something
> -not readably printable."
> +This function signals `server-return-invalid-read-syntax' if
> +`read' fails on the result returned by the server.
> +This will occur whenever the result of evaluating FORM is
> +something that cannot be printed readably."
>    (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir))
>           (server-file (expand-file-name server server-dir))
>           (coding-system-for-read 'binary)

Nice, this makes the wording seem less like a tautology, please install!

-- 
Sean Whitton

Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result

[Robert Pluim]

>>>>> On Sat, 11 Mar 2023 11:51:22 -0700, Sean Whitton <spwhitton@spwhitton.name> said:

    Sean> Hello,
    Sean> On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote:

    >> diff --git a/lisp/server.el b/lisp/server.el
    >> index 89aedc72d52..1bbfdced5b0 100644
    >> --- a/lisp/server.el
    >> +++ b/lisp/server.el
    >> @@ -1930,7 +1930,7 @@ server-unload-function
    >> nil)
    >> 
    >> (define-error 'server-return-invalid-read-syntax
    >> -              "Emacs server returned unreadable result of evaluation"
    >> +              "Result of evaluation by Emacs server is unreadable"
    >> 'invalid-read-syntax)

    Sean> I find this less good as a user-visible error message.

OK
    >> (defun server-eval-at (server form)
    >> @@ -1941,10 +1941,10 @@ server-eval-at
    >> 
    >> This function signals `error' if it could not contact the server.
    >> 
    >> -This function signals `server-return-invalid-read-syntax' if it
    >> -couldn't read the result of evaluation printed by the server.
    >> -This will occur whenever the result of evaluating FORM is something
    >> -not readably printable."
    >> +This function signals `server-return-invalid-read-syntax' if
    >> +`read' fails on the result returned by the server.
    >> +This will occur whenever the result of evaluating FORM is
    >> +something that cannot be printed readably."
    >> (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir))
    >> (server-file (expand-file-name server server-dir))
    >> (coding-system-for-read 'binary)

    Sean> Nice, this makes the wording seem less like a tautology, please install!

Done as b9a70865d2c

Robert
--