* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
@ 2011-08-30 10:55 Wilfred Hughes
2011-08-30 16:42 ` bug#9408: A simple patch Wilfred Hughes
2011-09-05 8:28 ` bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Juri Linkov
0 siblings, 2 replies; 9+ messages in thread
From: Wilfred Hughes @ 2011-08-30 10:55 UTC (permalink / raw)
To: 9408
1. disable colour for git by doing the following in a shell: $ git
config --global color.ui never
2. open a file that is in a git repository: (in my case: C-x C-f
~/gxbo/cron.yaml)
3. search for something that exists using vc-git-grep: (in my case: M-x
vc-git-grep RET backend RET * RET ~/gxbo RET)
4. results are returned that links to the files where the results were
found
5. enable colour for git: $ git config --global color.ui always
6. repeat the search with vc-git grep
7. results are just plain text and hitting RET on them gives "no git hit
here".
Compared with using grep, I note that my search term 'backend' is not
highlighted. I don't know if that's related.
Thanks.
In GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.5)
of 2011-08-21 on ovide
Windowing system distributor `The X.Org Foundation', version 11.0.11003901
configured using `configure '--prefix=/usr' '--sysconfdir=/etc'
'--libexecdir=/usr/lib' '--localstatedir=/var' '--without-sound'
'--with-x-toolkit=gtk' '--with-xft' 'CFLAGS=-march=x86-64
-mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4
-D_FORTIFY_SOURCE=2'
'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=gnu''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_GB.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: Fundamental
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
C-x C-f c r o n . y <tab> <return> M-x v c - g i <tab>
g r e <tab> <return> b a c k e n d <return> * <return>
C-f <return> <down-mouse-1> <mouse-1> M-x v c - g i
<tab> g <tab> <return> b a c k e n d <return> * <return>
<return> C-x o M-> M-< C-x o M-x r e p o r <tab> <
return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-git...done
call-interactively: End of buffer
Grep finished (matches found) [2 times]
Mark set [2 times]
Load-path shadows:
None found.
Features:
(shadow sort mail-extr message idna sendmail regexp-opt ecomplete rfc822
mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode
mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev
nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit
mailheader canlock sha1 hex-util hashcash mail-utils emacsbug grep
compile comint ring vc-git tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs)
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: A simple patch
2011-08-30 10:55 bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Wilfred Hughes
@ 2011-08-30 16:42 ` Wilfred Hughes
2011-09-01 7:30 ` Glenn Morris
2011-09-05 8:28 ` bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Juri Linkov
1 sibling, 1 reply; 9+ messages in thread
From: Wilfred Hughes @ 2011-08-30 16:42 UTC (permalink / raw)
To: 9408
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Fixing this should be just a matter of changing line 890 of vc-git.el:
(grep-expand-template "git grep -n -e <R> -- <F>" regexp files))
To:
(grep-expand-template "git grep --no-color -n -e <R> -- <F>" regexp files))
Generally --no-color is used, so I can't see any similar issues elsewhere.
[-- Attachment #2: Type: text/html, Size: 376 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: A simple patch
2011-08-30 16:42 ` bug#9408: A simple patch Wilfred Hughes
@ 2011-09-01 7:30 ` Glenn Morris
0 siblings, 0 replies; 9+ messages in thread
From: Glenn Morris @ 2011-09-01 7:30 UTC (permalink / raw)
To: 9408-done
Version: 24.1
Thanks; applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-08-30 10:55 bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Wilfred Hughes
2011-08-30 16:42 ` bug#9408: A simple patch Wilfred Hughes
@ 2011-09-05 8:28 ` Juri Linkov
2011-09-05 12:43 ` Wilfred Hughes
1 sibling, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2011-09-05 8:28 UTC (permalink / raw)
To: Wilfred Hughes; +Cc: 9408
> Compared with using grep, I note that my search term 'backend' is not
> highlighted. I don't know if that's related.
git-grep emits "\033[1;31m" escape sequences unlike expected "\033[01;31m"
as GNU Grep does. I fixed this in the Bzr repo, so now search terms can be
highlighted by `vc-git-grep'. Could you please try the fixed version now?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-09-05 8:28 ` bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Juri Linkov
@ 2011-09-05 12:43 ` Wilfred Hughes
2011-09-06 9:32 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Wilfred Hughes @ 2011-09-05 12:43 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9408
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
I built revision 105661, then ran $ src/emacs -Q but I did not get search
highlighting with vc-git-grep. File name highlighting works fine. My git
version is:
$ git --version
git version 1.7.6.1
On 5 September 2011 09:28, Juri Linkov <juri@jurta.org> wrote:
> > Compared with using grep, I note that my search term 'backend' is not
> > highlighted. I don't know if that's related.
>
> git-grep emits "\033[1;31m" escape sequences unlike expected "\033[01;31m"
> as GNU Grep does. I fixed this in the Bzr repo, so now search terms can be
> highlighted by `vc-git-grep'. Could you please try the fixed version now?
>
[-- Attachment #2: Type: text/html, Size: 950 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-09-05 12:43 ` Wilfred Hughes
@ 2011-09-06 9:32 ` Juri Linkov
2011-09-06 13:27 ` Wilfred Hughes
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2011-09-06 9:32 UTC (permalink / raw)
To: Wilfred Hughes; +Cc: 9408
> I built revision 105661, then ran $ src/emacs -Q but I did not get search
> highlighting with vc-git-grep. File name highlighting works fine. My git
> version is:
>
> $ git --version
> git version 1.7.6.1
My git version is 1.7.1 and I get search highlighting when I enable
colour for git with: $ git config --global color.ui auto
and when `git grep' runs without "--no-color".
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-09-06 9:32 ` Juri Linkov
@ 2011-09-06 13:27 ` Wilfred Hughes
2011-09-06 13:40 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Wilfred Hughes @ 2011-09-06 13:27 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9408
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Yes, using git grep without --no-color gets exactly the colour codes you
describe. But as of revision 105630 (the commit mentioned in message 13),
vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
suppresses search term highlighting. Have I missed something?
On 6 September 2011 10:32, Juri Linkov <juri@jurta.org> wrote:
> > I built revision 105661, then ran $ src/emacs -Q but I did not get search
> > highlighting with vc-git-grep. File name highlighting works fine. My git
> > version is:
> >
> > $ git --version
> > git version 1.7.6.1
>
> My git version is 1.7.1 and I get search highlighting when I enable
> colour for git with: $ git config --global color.ui auto
> and when `git grep' runs without "--no-color".
>
[-- Attachment #2: Type: text/html, Size: 1088 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-09-06 13:27 ` Wilfred Hughes
@ 2011-09-06 13:40 ` Juri Linkov
2011-09-06 14:06 ` Wilfred Hughes
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2011-09-06 13:40 UTC (permalink / raw)
To: Wilfred Hughes; +Cc: 9408
> Yes, using git grep without --no-color gets exactly the colour codes you
> describe. But as of revision 105630 (the commit mentioned in message 13),
> vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
> suppresses search term highlighting. Have I missed something?
You earlier suggested to add "--no-color" to `grep-expand-template'.
Do you think it now can be removed because now search terms are
highlighted correctly and you have no more problems with
hitting RET on them?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
2011-09-06 13:40 ` Juri Linkov
@ 2011-09-06 14:06 ` Wilfred Hughes
0 siblings, 0 replies; 9+ messages in thread
From: Wilfred Hughes @ 2011-09-06 14:06 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9408
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Oh, sorry. Yes, it can be removed and works perfectly. Many thanks.
On 6 September 2011 14:40, Juri Linkov <juri@jurta.org> wrote:
> > Yes, using git grep without --no-color gets exactly the colour codes you
> > describe. But as of revision 105630 (the commit mentioned in message 13),
> > vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
> > suppresses search term highlighting. Have I missed something?
>
> You earlier suggested to add "--no-color" to `grep-expand-template'.
> Do you think it now can be removed because now search terms are
> highlighted correctly and you have no more problems with
> hitting RET on them?
>
[-- Attachment #2: Type: text/html, Size: 969 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-09-06 14:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-30 10:55 bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Wilfred Hughes
2011-08-30 16:42 ` bug#9408: A simple patch Wilfred Hughes
2011-09-01 7:30 ` Glenn Morris
2011-09-05 8:28 ` bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Juri Linkov
2011-09-05 12:43 ` Wilfred Hughes
2011-09-06 9:32 ` Juri Linkov
2011-09-06 13:27 ` Wilfred Hughes
2011-09-06 13:40 ` Juri Linkov
2011-09-06 14:06 ` Wilfred Hughes
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).