From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wilfred Hughes Newsgroups: gmane.emacs.bugs Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Date: Mon, 5 Sep 2011 13:43:17 +0100 Message-ID: References: <87sjoci6tu.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=000e0cd290604fb4d504ac310fd5 X-Trace: dough.gmane.org 1315226682 29569 80.91.229.12 (5 Sep 2011 12:44:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Sep 2011 12:44:42 +0000 (UTC) Cc: 9408@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 05 14:44:35 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R0YXR-0000jS-Bf for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Sep 2011 14:44:33 +0200 Original-Received: from localhost ([::1]:39582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0YXQ-0007f9-TE for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Sep 2011 08:44:32 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:43740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0YXJ-0007K9-Ts for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2011 08:44:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0YXF-0001ww-En for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2011 08:44:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0YXE-0001wm-UI for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2011 08:44:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R0Yan-0006Gd-SZ; Mon, 05 Sep 2011 08:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2011 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131522685024053 (code B ref 9408); Mon, 05 Sep 2011 12:48:01 +0000 Original-Received: (at 9408) by debbugs.gnu.org; 5 Sep 2011 12:47:30 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0YaE-0006Fp-4y for submit@debbugs.gnu.org; Mon, 05 Sep 2011 08:47:30 -0400 Original-Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0Ya7-0006Fe-Km for 9408@debbugs.gnu.org; Mon, 05 Sep 2011 08:47:24 -0400 Original-Received: by iakc1 with SMTP id c1so6309119iak.3 for <9408@debbugs.gnu.org>; Mon, 05 Sep 2011 05:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=NCFzbcRZ8MCOMvs2UHYm4/LN2YE4wUZ+/nHkIbSEdRw=; b=gDJiVQwEDu9XspUAKB6WGJ27u102Epj/iwHH1+tB3szIJ5pjlJY/gzo5N0eilb8h89 nnQAgWDDwKWg2jKX+HpzWYZ5V0qF2QRcvTDHorz+8ceRjInkvasjCwn82cX3ffwkvqt2 RXeG6WsZfZS0UxcFM/Xgp37H0K2w+hplwkcyw= Original-Received: by 10.231.55.2 with SMTP id s2mr7587404ibg.37.1315226617099; Mon, 05 Sep 2011 05:43:37 -0700 (PDT) Original-Received: by 10.231.145.202 with HTTP; Mon, 5 Sep 2011 05:43:17 -0700 (PDT) In-Reply-To: <87sjoci6tu.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 05 Sep 2011 08:48:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50611 Archived-At: --000e0cd290604fb4d504ac310fd5 Content-Type: text/plain; charset=UTF-8 I built revision 105661, then ran $ src/emacs -Q but I did not get search highlighting with vc-git-grep. File name highlighting works fine. My git version is: $ git --version git version 1.7.6.1 On 5 September 2011 09:28, Juri Linkov wrote: > > Compared with using grep, I note that my search term 'backend' is not > > highlighted. I don't know if that's related. > > git-grep emits "\033[1;31m" escape sequences unlike expected "\033[01;31m" > as GNU Grep does. I fixed this in the Bzr repo, so now search terms can be > highlighted by `vc-git-grep'. Could you please try the fixed version now? > --000e0cd290604fb4d504ac310fd5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I built revision 105661, then ran $ src/emacs -Q but I did not get search h= ighlighting with vc-git-grep. File name highlighting works fine. My git ver= sion is:

$ git --version
git version 1.7.6.1

On 5 September 2011 09:28, Juri Linkov <juri@jurta.org> wrote:
> Compared with using grep, I note that my search term= 'backend' is not
> highlighted. I don't know if that's related.

git-grep emits "\033[1;31m" escape sequences unlike expecte= d "\033[01;31m"
as GNU Grep does. =C2=A0I fixed this in the Bzr repo, so now search terms c= an be
highlighted by `vc-git-grep'. =C2=A0Could you please try the fixed vers= ion now?

--000e0cd290604fb4d504ac310fd5--