From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wilfred Hughes Newsgroups: gmane.emacs.bugs Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Date: Tue, 6 Sep 2011 14:27:31 +0100 Message-ID: References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=90e6ba613854577d4c04ac45cb21 X-Trace: dough.gmane.org 1315315712 24801 80.91.229.12 (6 Sep 2011 13:28:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2011 13:28:32 +0000 (UTC) Cc: 9408@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 15:28:25 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vhQ-0000Gi-IW for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 15:28:24 +0200 Original-Received: from localhost ([::1]:60235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vhP-0001Eb-Om for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 09:28:23 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vhI-0001EA-8m for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:28:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0vhH-000429-70 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:28:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vhH-000425-2Q for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:28:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R0vkv-0005jK-Lc; Tue, 06 Sep 2011 09:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 13:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531590522005 (code B ref 9408); Tue, 06 Sep 2011 13:32:01 +0000 Original-Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 13:31:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vke-0005ir-OW for submit@debbugs.gnu.org; Tue, 06 Sep 2011 09:31:45 -0400 Original-Received: from mail-yx0-f172.google.com ([209.85.213.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vkZ-0005ig-2I for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 09:31:41 -0400 Original-Received: by yxj17 with SMTP id 17so2564629yxj.3 for <9408@debbugs.gnu.org>; Tue, 06 Sep 2011 06:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=+oEAuDSjs44Q5xy0D4rbhMzxbyCMDvFCJFJGMMPeWGU=; b=gCuhqVqq1T5wnUIjTpW972meBOZO4AjQVrX2WfJjMgDwaoPMhzIYcx5efuOyrXS9i5 wbjFFZQ3jG1XzH7ZKgG2iBV/6CIPRvLQpEKQGIRmSF5wry6HQjcPyMx5uTi1yrUEeG9+ bwN9xB5AqKF7ahbup0W4HPkW5DOnEG70kMul8= Original-Received: by 10.42.168.136 with SMTP id w8mr4747925icy.267.1315315671071; Tue, 06 Sep 2011 06:27:51 -0700 (PDT) Original-Received: by 10.231.145.202 with HTTP; Tue, 6 Sep 2011 06:27:31 -0700 (PDT) In-Reply-To: <87bouyj9rt.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Sep 2011 09:32:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50633 Archived-At: --90e6ba613854577d4c04ac45cb21 Content-Type: text/plain; charset=UTF-8 Yes, using git grep without --no-color gets exactly the colour codes you describe. But as of revision 105630 (the commit mentioned in message 13), vc-git-grep uses the command "git grep --no-color -n -e -- " which suppresses search term highlighting. Have I missed something? On 6 September 2011 10:32, Juri Linkov wrote: > > I built revision 105661, then ran $ src/emacs -Q but I did not get search > > highlighting with vc-git-grep. File name highlighting works fine. My git > > version is: > > > > $ git --version > > git version 1.7.6.1 > > My git version is 1.7.1 and I get search highlighting when I enable > colour for git with: $ git config --global color.ui auto > and when `git grep' runs without "--no-color". > --90e6ba613854577d4c04ac45cb21 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, using git grep without --no-color gets exactly the colour codes you de= scribe. But as of revision 105630 (the commit mentioned in message 13), vc-= git-grep uses the command "git grep --no-color -n -e <R> -- <= F>" which suppresses search term highlighting. Have I missed someth= ing?

On 6 September 2011 10:32, Juri Linkov <juri@jurta.org> wrote:
> I built revision 105661, then ran $ src/emacs -Q but= I did not get search
> highlighting with vc-git-grep. File name highlighting works fine. My g= it
> version is:
>
> $ git --version
> git version 1.7.6.1

My git version is 1.7.1 and I get search highlighting when I enable colour for git with: $ git config --global color.ui auto
and when `git grep' runs without "--no-color".

--90e6ba613854577d4c04ac45cb21--