From: Wilfred Hughes <wilfred@potatolondon.com>
To: Juri Linkov <juri@jurta.org>
Cc: 9408@debbugs.gnu.org
Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour
Date: Tue, 6 Sep 2011 14:27:31 +0100 [thread overview]
Message-ID: <CAMJPRQxvvvgA-j7TCYxU1oeVz5uexuAknKbjvNrAz+Ybneffwg@mail.gmail.com> (raw)
In-Reply-To: <87bouyj9rt.fsf@mail.jurta.org>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Yes, using git grep without --no-color gets exactly the colour codes you
describe. But as of revision 105630 (the commit mentioned in message 13),
vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
suppresses search term highlighting. Have I missed something?
On 6 September 2011 10:32, Juri Linkov <juri@jurta.org> wrote:
> > I built revision 105661, then ran $ src/emacs -Q but I did not get search
> > highlighting with vc-git-grep. File name highlighting works fine. My git
> > version is:
> >
> > $ git --version
> > git version 1.7.6.1
>
> My git version is 1.7.1 and I get search highlighting when I enable
> colour for git with: $ git config --global color.ui auto
> and when `git grep' runs without "--no-color".
>
[-- Attachment #2: Type: text/html, Size: 1088 bytes --]
next prev parent reply other threads:[~2011-09-06 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 10:55 bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Wilfred Hughes
2011-08-30 16:42 ` bug#9408: A simple patch Wilfred Hughes
2011-09-01 7:30 ` Glenn Morris
2011-09-05 8:28 ` bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Juri Linkov
2011-09-05 12:43 ` Wilfred Hughes
2011-09-06 9:32 ` Juri Linkov
2011-09-06 13:27 ` Wilfred Hughes [this message]
2011-09-06 13:40 ` Juri Linkov
2011-09-06 14:06 ` Wilfred Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMJPRQxvvvgA-j7TCYxU1oeVz5uexuAknKbjvNrAz+Ybneffwg@mail.gmail.com \
--to=wilfred@potatolondon.com \
--cc=9408@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).