From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Date: Tue, 06 Sep 2011 16:40:10 +0300 Organization: JURTA Message-ID: <871uvtiybp.fsf@mail.jurta.org> References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315316558 31909 80.91.229.12 (6 Sep 2011 13:42:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2011 13:42:38 +0000 (UTC) Cc: 9408@debbugs.gnu.org To: Wilfred Hughes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 15:42:34 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vv2-0007oT-3X for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 15:42:28 +0200 Original-Received: from localhost ([::1]:39111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vv1-0005rf-Io for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 09:42:27 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vut-0005f9-FL for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:42:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0vup-00076H-En for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:42:19 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vup-000762-DJ for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 09:42:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R0vyT-0006iU-T6; Tue, 06 Sep 2011 09:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531674625797 (code B ref 9408); Tue, 06 Sep 2011 13:46:01 +0000 Original-Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 13:45:46 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vyD-0006i1-Hc for submit@debbugs.gnu.org; Tue, 06 Sep 2011 09:45:46 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0vyA-0006ht-6f for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 09:45:43 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 1C9E86E8065; Tue, 6 Sep 2011 06:41:54 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F15B3451C42E; Tue, 6 Sep 2011 06:41:52 -0700 (PDT) In-Reply-To: (Wilfred Hughes's message of "Tue, 6 Sep 2011 14:27:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Sep 2011 09:46:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50634 Archived-At: > Yes, using git grep without --no-color gets exactly the colour codes you > describe. But as of revision 105630 (the commit mentioned in message 13), > vc-git-grep uses the command "git grep --no-color -n -e -- " which > suppresses search term highlighting. Have I missed something? You earlier suggested to add "--no-color" to `grep-expand-template'. Do you think it now can be removed because now search terms are highlighted correctly and you have no more problems with hitting RET on them?