From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wilfred Hughes Newsgroups: gmane.emacs.bugs Subject: bug#9408: 23.3; vc-git-grep doesn't link to files when git grep uses colour Date: Tue, 6 Sep 2011 15:06:45 +0100 Message-ID: References: <87sjoci6tu.fsf@mail.jurta.org> <87bouyj9rt.fsf@mail.jurta.org> <871uvtiybp.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=20cf3042719051ebd604ac46586a X-Trace: dough.gmane.org 1315318117 11720 80.91.229.12 (6 Sep 2011 14:08:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2011 14:08:37 +0000 (UTC) Cc: 9408@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 16:08:33 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R0wKF-0004wO-NQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 16:08:31 +0200 Original-Received: from localhost ([::1]:51519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0wKF-0005zV-5N for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 10:08:31 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0wK4-0005xm-9D for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 10:08:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0wJy-0003Te-Rj for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 10:08:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0wJy-0003TY-Lq for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 10:08:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R0wNd-00084W-KW; Tue, 06 Sep 2011 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilfred Hughes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9408-submit@debbugs.gnu.org id=B9408.131531826830966 (code B ref 9408); Tue, 06 Sep 2011 14:12:01 +0000 Original-Received: (at 9408) by debbugs.gnu.org; 6 Sep 2011 14:11:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0wMl-00083O-Jm for submit@debbugs.gnu.org; Tue, 06 Sep 2011 10:11:07 -0400 Original-Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0wMi-00083F-FZ for 9408@debbugs.gnu.org; Tue, 06 Sep 2011 10:11:06 -0400 Original-Received: by gxk19 with SMTP id 19so3511180gxk.3 for <9408@debbugs.gnu.org>; Tue, 06 Sep 2011 07:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=potatolondon.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=NNUb33aepzHtu1lTGlwsAq2KhrjFCfqrRFacI4Q2BXE=; b=REt7gxsHw1mojXU93t+UXzBdooJYcGWR3zmyzHw9+gFXCokl9kDimy5ZzxKPexa3eZ 9weGg5akB3m/oPkkY9vonso2Hp91l3A/m14giF8CGIQIgW0UNmY3BmyueV2Aq7bHGFZ3 mddinbqcxwh0qdS6EeOHmMOFv0dN4FaZfheds= Original-Received: by 10.42.28.135 with SMTP id n7mr4691201icc.200.1315318036294; Tue, 06 Sep 2011 07:07:16 -0700 (PDT) Original-Received: by 10.231.145.202 with HTTP; Tue, 6 Sep 2011 07:06:45 -0700 (PDT) In-Reply-To: <871uvtiybp.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Sep 2011 10:12:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50636 Archived-At: --20cf3042719051ebd604ac46586a Content-Type: text/plain; charset=UTF-8 Oh, sorry. Yes, it can be removed and works perfectly. Many thanks. On 6 September 2011 14:40, Juri Linkov wrote: > > Yes, using git grep without --no-color gets exactly the colour codes you > > describe. But as of revision 105630 (the commit mentioned in message 13), > > vc-git-grep uses the command "git grep --no-color -n -e -- " which > > suppresses search term highlighting. Have I missed something? > > You earlier suggested to add "--no-color" to `grep-expand-template'. > Do you think it now can be removed because now search terms are > highlighted correctly and you have no more problems with > hitting RET on them? > --20cf3042719051ebd604ac46586a Content-Type: text/html; charset=UTF-8 Oh, sorry. Yes, it can be removed and works perfectly. Many thanks.

On 6 September 2011 14:40, Juri Linkov <juri@jurta.org> wrote:
> Yes, using git grep without --no-color gets exactly the colour codes you
> describe. But as of revision 105630 (the commit mentioned in message 13),
> vc-git-grep uses the command "git grep --no-color -n -e <R> -- <F>" which
> suppresses search term highlighting. Have I missed something?

You earlier suggested to add "--no-color" to `grep-expand-template'.
Do you think it now can be removed because now search terms are
highlighted correctly and you have no more problems with
hitting RET on them?

--20cf3042719051ebd604ac46586a--