* notmuch-emacs: avoiding deprecated message-default-charset
@ 2019-04-20 20:00 Daniel Kahn Gillmor
2019-04-21 14:41 ` David Bremner
0 siblings, 1 reply; 16+ messages in thread
From: Daniel Kahn Gillmor @ 2019-04-20 20:00 UTC (permalink / raw)
To: Notmuch Mail
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
When i'm building notmuch in a debian environment with emacs
1:26.1+1-3.2, i notice the following deprecation warnings:
In notmuch-maildir-setup-message-for-saving:
emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
obsolete variable (as of 26.1); The default charset comes from the
language environment
I'm not enough of an emacs guru to know the right way to avoid this
warning, but i'm hoping that someonen else can take a stab at it, since
extraneous warnings make it easier to ignore real problems.
Sorry to provide a bug report with no proposed patch :/
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-20 20:00 notmuch-emacs: avoiding deprecated message-default-charset Daniel Kahn Gillmor @ 2019-04-21 14:41 ` David Bremner 2019-04-21 19:25 ` Daniel Kahn Gillmor 0 siblings, 1 reply; 16+ messages in thread From: David Bremner @ 2019-04-21 14:41 UTC (permalink / raw) To: Daniel Kahn Gillmor, Notmuch Mail Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > When i'm building notmuch in a debian environment with emacs > 1:26.1+1-3.2, i notice the following deprecation warnings: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > I'm not enough of an emacs guru to know the right way to avoid this > warning, but i'm hoping that someonen else can take a stab at it, since > extraneous warnings make it easier to ignore real problems. Good question. I looked at message.el in emacs master and it 1) Obsoletes message-default-charset as in 26.1 2) Still uses it in exactly the construction we do. I'm not sure if it's exactly a reportable bug in emacs, but it is a bit annoying. There is a variable byte-compile-not-obsolete-vars that (probably) can be used to suppress that warning, but it's not clear that's a good idea (we currently do something similar for Xapian obsolescence warnings that we can't fix). d ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-21 14:41 ` David Bremner @ 2019-04-21 19:25 ` Daniel Kahn Gillmor 2019-04-21 22:05 ` bug#35370: " Noam Postavsky 0 siblings, 1 reply; 16+ messages in thread From: Daniel Kahn Gillmor @ 2019-04-21 19:25 UTC (permalink / raw) To: David Bremner, Notmuch Mail, bug-gnu-emacs [-- Attachment #1: Type: text/plain, Size: 1704 bytes --] On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote: > Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > >> When i'm building notmuch in a debian environment with emacs >> 1:26.1+1-3.2, i notice the following deprecation warnings: >> >> In notmuch-maildir-setup-message-for-saving: >> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an >> obsolete variable (as of 26.1); The default charset comes from the >> language environment >> >> I'm not enough of an emacs guru to know the right way to avoid this >> warning, but i'm hoping that someonen else can take a stab at it, since >> extraneous warnings make it easier to ignore real problems. > > Good question. I looked at message.el in emacs master and it > > 1) Obsoletes message-default-charset as in 26.1 > 2) Still uses it in exactly the construction we do. interesting, thanks for digging that up. > I'm not sure if it's exactly a reportable bug in emacs, but it is a bit > annoying. seems reportable, if not exactly high-severity. what does upstream expect downstream users of message-default-charset to do? I'm (trying to) forward this to the emacs upstream bugtracker; maybe we can get guidance from them on what to do. > There is a variable byte-compile-not-obsolete-vars that (probably) can > be used to suppress that warning, but it's not clear that's a good > idea (we currently do something similar for Xapian obsolescence warnings > that we can't fix). I would generally try to avoid that kind of a bypass, because i tend to think that warnings are reasonable to look out for and try to fix before they become real problems. --dkg [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 227 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-21 19:25 ` Daniel Kahn Gillmor @ 2019-04-21 22:05 ` Noam Postavsky 2019-04-22 1:55 ` Daniel Kahn Gillmor 0 siblings, 1 reply; 16+ messages in thread From: Noam Postavsky @ 2019-04-21 22:05 UTC (permalink / raw) To: Daniel Kahn Gillmor; +Cc: david, notmuch, 35370 Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs guru to know the right way to avoid this >>> warning, but i'm hoping that someonen else can take a stab at it, since >>> extraneous warnings make it easier to ignore real problems. >> >> Good question. I looked at message.el in emacs master and it >> >> 1) Obsoletes message-default-charset as in 26.1 >> 2) Still uses it in exactly the construction we do. > > interesting, thanks for digging that up. > >> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit >> annoying. > > seems reportable, if not exactly high-severity. what does upstream > expect downstream users of message-default-charset to do? I'm > (trying to) forward this to the emacs upstream bugtracker; maybe we can > get guidance from them on what to do. The commit which marks this variable as obsolete, has a couple hunks that just remove uses of it. Not clear why other uses were left in. Oversight? [1: 66d9ef95c0]: 2016-02-14 17:07:48 +1100 Remove compat code for older Emacsen https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=66d9ef95c0f9407d2a6d26bcd7ed84a303294b53 --- a/lisp/gnus/gnus-int.el +++ b/lisp/gnus/gnus-int.el @@ -777,8 +777,7 @@ (defun gnus-request-accept-article (group &optional gnus-command-method last (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let ((gnus-command-method (or gnus-command-method (gnus-find-method-for-group group))) @@ -800,8 +799,7 @@ (defun gnus-request-replace-article (article group buffer &optional no-encode) (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let* ((func (car (gnus-group-name-to-method group))) (result (funcall (intern (format "%s-request-replace-article" func)) ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-21 22:05 ` bug#35370: " Noam Postavsky @ 2019-04-22 1:55 ` Daniel Kahn Gillmor 2019-04-22 6:33 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Daniel Kahn Gillmor @ 2019-04-22 1:55 UTC (permalink / raw) To: Noam Postavsky; +Cc: david, notmuch, 35370 [-- Attachment #1: Type: text/plain, Size: 444 bytes --] On Sun 2019-04-21 18:05:19 -0400, Noam Postavsky wrote: > The commit which marks this variable as obsolete, has a couple hunks > that just remove uses of it. Not clear why other uses were left in. > Oversight? Thanks, Noam! If that's the right thing for emacs itself, that's good to know. Do you have any recommendation for how an external emacs module (which aims to work with at emacs 25 as well at least) should handle this? --dkg [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 227 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-22 1:55 ` Daniel Kahn Gillmor @ 2019-04-22 6:33 ` Eli Zaretskii 2019-04-22 14:21 ` Daniel Kahn Gillmor 2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky 0 siblings, 2 replies; 16+ messages in thread From: Eli Zaretskii @ 2019-04-22 6:33 UTC (permalink / raw) To: Daniel Kahn Gillmor; +Cc: npostavs, david, notmuch, 35370 > From: Daniel Kahn Gillmor <dkg@fifthhorseman.net> > Date: Sun, 21 Apr 2019 21:55:38 -0400 > Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > > Do you have any recommendation for how an external emacs module (which > aims to work with at emacs 25 as well at least) should handle this? Just remove any uses of it. Why are you using it now? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-22 6:33 ` Eli Zaretskii @ 2019-04-22 14:21 ` Daniel Kahn Gillmor 2019-04-22 15:37 ` Eli Zaretskii 2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky 1 sibling, 1 reply; 16+ messages in thread From: Daniel Kahn Gillmor @ 2019-04-22 14:21 UTC (permalink / raw) To: Eli Zaretskii; +Cc: npostavs, david, notmuch, 35370 [-- Attachment #1: Type: text/plain, Size: 873 bytes --] Hi Eli-- Thanks for the prompt followup! On Mon 2019-04-22 09:33:26 +0300, Eli Zaretskii wrote: > [dkg wrote:] >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are you using it now? in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning of this thread: https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172 If we remove that entry from the (let) block, what are the implications for users of notmuch who are still using emacs 25? I don't have much knowledge in the way of deep emacs or message-mode internals, so if there's answer that's obvious to you that you think i'm missing, feel free to just point me to it. Thanks! --dkg [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 227 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-22 14:21 ` Daniel Kahn Gillmor @ 2019-04-22 15:37 ` Eli Zaretskii 2019-04-22 20:51 ` [PATCH] emacs: drop use of message-default-charset Daniel Kahn Gillmor 0 siblings, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2019-04-22 15:37 UTC (permalink / raw) To: Daniel Kahn Gillmor; +Cc: npostavs, david, notmuch, 35370 > From: Daniel Kahn Gillmor <dkg@fifthhorseman.net> > Cc: npostavs@gmail.com, david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > Date: Mon, 22 Apr 2019 10:21:25 -0400 > > > Just remove any uses of it. Why are you using it now? > > in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning > of this thread: > > https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172 > > If we remove that entry from the (let) block, what are the implications > for users of notmuch who are still using emacs 25? Nothing, I think. But if you don't want to risk problems, you can use it dependent on the Emacs version. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] emacs: drop use of message-default-charset 2019-04-22 15:37 ` Eli Zaretskii @ 2019-04-22 20:51 ` Daniel Kahn Gillmor 2019-04-22 21:23 ` Tomi Ollila 2019-05-07 9:38 ` David Bremner 0 siblings, 2 replies; 16+ messages in thread From: Daniel Kahn Gillmor @ 2019-04-22 20:51 UTC (permalink / raw) To: Notmuch Mail; +Cc: 35370 Apparently, message-default-charset is deprecated, which causes the following warning messages during the build: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset comes from the language environment In discussion with emacs upstream over on https://debbugs.gnu.org/35370, it appears that we can just drop this entirely and things should still work with emacs 25. --- emacs/notmuch-maildir-fcc.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 1551e8b6..ae56bacd 100644 --- a/emacs/notmuch-maildir-fcc.el +++ b/emacs/notmuch-maildir-fcc.el @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." (message-encode-message-body) (save-restriction (message-narrow-to-headers) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-min)) (when (re-search-forward (concat "^" (regexp-quote mail-header-separator) "$") -- 2.20.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] emacs: drop use of message-default-charset 2019-04-22 20:51 ` [PATCH] emacs: drop use of message-default-charset Daniel Kahn Gillmor @ 2019-04-22 21:23 ` Tomi Ollila 2019-05-07 9:38 ` David Bremner 1 sibling, 0 replies; 16+ messages in thread From: Tomi Ollila @ 2019-04-22 21:23 UTC (permalink / raw) To: Daniel Kahn Gillmor, Notmuch Mail; +Cc: 35370 On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > In discussion with emacs upstream over on > https://debbugs.gnu.org/35370, it appears that we can just drop this > entirely and things should still work with emacs 25. I looked this a bit (well, quite a few minutes, rfc2047.el in emacs 24.3, 25.2 and 26.1), and while it is impossible to gain any real knowledge with such a shallow peek, I'd guess the following might be true: Since `mail-parse-charset` and `message-default-charset` are (were) both `nil` by default, this change does have any effect for users that never customized message-default-charset. If anyone did, now there is small chance that the line: "If nil, you might be asked to input the charset." (from message-default-charset docstring) can happen. In this context the change is IMO even more unlikely. So this change LGTM. Tomi > --- > emacs/notmuch-maildir-fcc.el | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el > index 1551e8b6..ae56bacd 100644 > --- a/emacs/notmuch-maildir-fcc.el > +++ b/emacs/notmuch-maildir-fcc.el > @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." > (message-encode-message-body) > (save-restriction > (message-narrow-to-headers) > - (let ((mail-parse-charset message-default-charset)) > - (mail-encode-encoded-word-buffer))) > + (mail-encode-encoded-word-buffer)) > (goto-char (point-min)) > (when (re-search-forward > (concat "^" (regexp-quote mail-header-separator) "$") > -- > 2.20.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] emacs: drop use of message-default-charset 2019-04-22 20:51 ` [PATCH] emacs: drop use of message-default-charset Daniel Kahn Gillmor 2019-04-22 21:23 ` Tomi Ollila @ 2019-05-07 9:38 ` David Bremner 1 sibling, 0 replies; 16+ messages in thread From: David Bremner @ 2019-05-07 9:38 UTC (permalink / raw) To: Daniel Kahn Gillmor, Notmuch Mail; +Cc: 35370 Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > In discussion with emacs upstream over on > https://debbugs.gnu.org/35370, it appears that we can just drop this > entirely and things should still work with emacs 25. pushed d ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-04-22 6:33 ` Eli Zaretskii 2019-04-22 14:21 ` Daniel Kahn Gillmor @ 2019-05-07 12:26 ` Noam Postavsky 2019-05-07 14:36 ` Eli Zaretskii 1 sibling, 1 reply; 16+ messages in thread From: Noam Postavsky @ 2019-05-07 12:26 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Daniel Kahn Gillmor, david, notmuch, 35370 [-- Attachment #1: Type: text/plain, Size: 473 bytes --] Eli Zaretskii <eliz@gnu.org> writes: >> From: Daniel Kahn Gillmor <dkg@fifthhorseman.net> >> Date: Sun, 21 Apr 2019 21:55:38 -0400 >> Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org >> >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are you using it now? Should we remove the remaining uses of it from Emacs too? [-- Attachment #2: patch --] [-- Type: text/plain, Size: 3300 bytes --] From a3dca9511e1639ccfdf06bced16af5babb5078de Mon Sep 17 00:00:00 2001 From: Noam Postavsky <npostavs@gmail.com> Date: Tue, 7 May 2019 08:18:49 -0400 Subject: [PATCH] Stop using message-default-charset (Bug#35370) In 2016-02-14 "Remove compat code for older Emacsen", message-default-charset was obsoleted, and a couple of uses were removed, but others were left behind. * lisp/gnus/message.el (message-send-mail) (message-send-news, message-do-fcc) (message-encode-message-body): * lisp/gnus/mml.el (mml-to-mime): Stop using message-default-charset. --- lisp/gnus/message.el | 13 ++++--------- lisp/gnus/mml.el | 4 +--- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index c8b6f0ee68..2c2122d89a 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4588,8 +4588,7 @@ (defun message-send-mail (&optional _) (message-generate-headers '(Lines))) ;; Remove some headers. (message-remove-header message-ignored-mail-headers t) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-max)) ;; require one newline at the end. (or (= (preceding-char) ?\n) @@ -4962,8 +4961,7 @@ (defun message-send-news (&optional arg) (message-generate-headers '(Lines))) ;; Remove some headers. (message-remove-header message-ignored-news-headers t) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-max)) ;; require one newline at the end. (or (= (preceding-char) ?\n) @@ -5441,8 +5439,7 @@ (defun message-do-fcc () (while (setq file (message-fetch-field "fcc" t)) (push file list) (message-remove-header "fcc" nil t)) - (let ((mail-parse-charset message-default-charset) - (rfc2047-header-encoding-alist + (let ((rfc2047-header-encoding-alist (cons '("Newsgroups" . default) rfc2047-header-encoding-alist))) (mail-encode-encoded-word-buffer))) @@ -8101,9 +8098,7 @@ (defun message-clone-locals (buffer &optional varstr) (defun message-encode-message-body () (unless message-inhibit-body-encoding - (let ((mail-parse-charset (or mail-parse-charset - message-default-charset)) - (case-fold-search t) + (let ((case-fold-search t) lines content-type-p) (message-goto-body) (save-restriction diff --git a/lisp/gnus/mml.el b/lisp/gnus/mml.el index f6d358dfc0..7a99a0dc46 100644 --- a/lisp/gnus/mml.el +++ b/lisp/gnus/mml.el @@ -48,7 +48,6 @@ (autoload 'message-mail-p "message") (defvar gnus-article-mime-handles) (defvar gnus-newsrc-hashtb) -(defvar message-default-charset) (defvar message-deletable-headers) (defvar message-options) (defvar message-posting-charset) @@ -1015,8 +1014,7 @@ (defun mml-to-mime () ;; Skip past any From_ headers. (while (looking-at "From ") (forward-line 1)) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body)) (defun mml-insert-mime (handle &optional no-markup) -- 2.11.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky @ 2019-05-07 14:36 ` Eli Zaretskii 2019-05-09 18:33 ` Lars Ingebrigtsen 0 siblings, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2019-05-07 14:36 UTC (permalink / raw) To: Noam Postavsky, Lars Ingebrigtsen; +Cc: dkg, david, notmuch, 35370 > From: Noam Postavsky <npostavs@gmail.com> > Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > Date: Tue, 07 May 2019 08:26:59 -0400 > > > Just remove any uses of it. Why are you using it now? > > Should we remove the remaining uses of it from Emacs too? I think so, but I'd be happier if someone from the Gnus folks could eyeball this patch. Lars, any comments/objections? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-05-07 14:36 ` Eli Zaretskii @ 2019-05-09 18:33 ` Lars Ingebrigtsen 2019-05-10 5:32 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Lars Ingebrigtsen @ 2019-05-09 18:33 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Noam Postavsky, david, notmuch, dkg, 35370 Eli Zaretskii <eliz@gnu.org> writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-05-09 18:33 ` Lars Ingebrigtsen @ 2019-05-10 5:32 ` Eli Zaretskii 2019-05-10 10:45 ` Noam Postavsky 0 siblings, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2019-05-10 5:32 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: npostavs, david, notmuch, dkg, 35370 > From: Lars Ingebrigtsen <larsi@gnus.org> > Cc: Noam Postavsky <npostavs@gmail.com>, david@tethera.net, notmuch@notmuchmail.org, dkg@fifthhorseman.net, 35370@debbugs.gnu.org > Date: Thu, 09 May 2019 14:33:15 -0400 > > Eli Zaretskii <eliz@gnu.org> writes: > > > I think so, but I'd be happier if someone from the Gnus folks could > > eyeball this patch. > > > > Lars, any comments/objections? > > I think the patch looks OK -- it'll change the behaviour if you have > set enable-multibyte-characters to nil, but... does anybody do that? If they do, it's their funeral. Noam, please go ahead, and thanks. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset 2019-05-10 5:32 ` Eli Zaretskii @ 2019-05-10 10:45 ` Noam Postavsky 0 siblings, 0 replies; 16+ messages in thread From: Noam Postavsky @ 2019-05-10 10:45 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, david, notmuch, dkg, 35370 close 35370 quit Eli Zaretskii <eliz@gnu.org> writes: >> From: Lars Ingebrigtsen <larsi@gnus.org> >> I think the patch looks OK -- it'll change the behaviour if you have >> set enable-multibyte-characters to nil, but... does anybody do that? > > If they do, it's their funeral. > > Noam, please go ahead, and thanks. Done. 510aa7505f 2019-05-10T06:41:59-04:00 "Stop using message-default-charset (Bug#35370)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=510aa7505fc14e0ebc6a0d220160397f068c5c04 ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-05-10 10:45 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-20 20:00 notmuch-emacs: avoiding deprecated message-default-charset Daniel Kahn Gillmor 2019-04-21 14:41 ` David Bremner 2019-04-21 19:25 ` Daniel Kahn Gillmor 2019-04-21 22:05 ` bug#35370: " Noam Postavsky 2019-04-22 1:55 ` Daniel Kahn Gillmor 2019-04-22 6:33 ` Eli Zaretskii 2019-04-22 14:21 ` Daniel Kahn Gillmor 2019-04-22 15:37 ` Eli Zaretskii 2019-04-22 20:51 ` [PATCH] emacs: drop use of message-default-charset Daniel Kahn Gillmor 2019-04-22 21:23 ` Tomi Ollila 2019-05-07 9:38 ` David Bremner 2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky 2019-05-07 14:36 ` Eli Zaretskii 2019-05-09 18:33 ` Lars Ingebrigtsen 2019-05-10 5:32 ` Eli Zaretskii 2019-05-10 10:45 ` Noam Postavsky
Code repositories for project(s) associated with this public inbox https://yhetil.org/notmuch.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).