From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3B2B16DE0EC7 for ; Sun, 21 Apr 2019 15:05:23 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.2 X-Spam-Level: X-Spam-Status: No, score=-0.2 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qWSjghvqxs1f for ; Sun, 21 Apr 2019 15:05:22 -0700 (PDT) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by arlo.cworth.org (Postfix) with ESMTPS id 3F81A6DE0BCD for ; Sun, 21 Apr 2019 15:05:22 -0700 (PDT) Received: by mail-qk1-f181.google.com with SMTP id g1so5506912qki.5 for ; Sun, 21 Apr 2019 15:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=d36q+JEtWxK7pf517F6qDdMW0JWG3qmNDYf61rhNWzZSt0n2m/ZWYpZThIrWXWBmYf U1ec1iZBbVx3f8rXFnhhSqtejiFbjr6jeWmxoRp6P/yXxrx7rujhXG+nfPnsrEN9nUxl dwuITFklqWXi1jVDVjpVq9YRMa1AcpNkCGWGrBJtiX6P80nLJ69j4X03S7c1kQxCOr7E cUr292Q0fLTp0fdPBKb+f0FnQ4D8TMjJcL7ErSP4qSpGqbHU7uAkBRn9ABJMN6vhMDPT vOgiQnuXR1twhc3p3CCdgz+C9dW7MV6bKkl1XBeTfrbUPQ4lJ+nLHls7RsavPshkJRYo 2H9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=pRDsRLMCQjLD211nfYkjEnej1hSEX0+vb/KN+C4DNe1Q5PzgiaWoUsE6ce9LfkvwkK AT+7s9p6qt7K9958T8DLM67HQ/h6cD6lQMr95bsl1uHvOitng3GkwG3AfFyMfcCBup6U chjfu7FeTcBG7mrCtB+uG2sQBhI/E7aKFra6i3p8epXSS04N7NHdoXUHDhTt+4v8Ut2t i5svDR+jkyUOI6RaWi5jngX7qSZQ8V/DqkRwoKZeBGpznCBQ4Js8P2m3ifKtIwjRcewB BjhFE+02UObPbRDGQHL0RkxdbjwOC4cwY5wTWRFI7r12YN9/UetOq8ajNdk9EMPXZYdw /WMQ== X-Gm-Message-State: APjAAAXLghRr1RpXgpa0P52ajamnWhoQEbB2lbAYNVCUEVOtEg+mfMnG II3v7pd+zFrWsmzb160pNLs= X-Google-Smtp-Source: APXvYqzoZ6QssbIIaiPOSIm5G1ZlvqqbxOQjVrrSCW5XVR4/9kC4JITvfJ6cUuF1GS6mZbg3L8spwQ== X-Received: by 2002:ae9:e107:: with SMTP id g7mr12546255qkm.272.1555884321253; Sun, 21 Apr 2019 15:05:21 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p46sm7095997qtc.41.2019.04.21.15.05.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Apr 2019 15:05:20 -0700 (PDT) From: Noam Postavsky To: Daniel Kahn Gillmor Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> Date: Sun, 21 Apr 2019 18:05:19 -0400 In-Reply-To: <87a7gjw479.fsf@fifthhorseman.net> (Daniel Kahn Gillmor's message of "Sun, 21 Apr 2019 15:25:46 -0400") Message-ID: <87sgubrp40.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 22 Apr 2019 03:10:17 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2019 22:05:23 -0000 Daniel Kahn Gillmor writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs guru to know the right way to avoid this >>> warning, but i'm hoping that someonen else can take a stab at it, since >>> extraneous warnings make it easier to ignore real problems. >> >> Good question. I looked at message.el in emacs master and it >> >> 1) Obsoletes message-default-charset as in 26.1 >> 2) Still uses it in exactly the construction we do. > > interesting, thanks for digging that up. > >> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit >> annoying. > > seems reportable, if not exactly high-severity. what does upstream > expect downstream users of message-default-charset to do? I'm > (trying to) forward this to the emacs upstream bugtracker; maybe we can > get guidance from them on what to do. The commit which marks this variable as obsolete, has a couple hunks that just remove uses of it. Not clear why other uses were left in. Oversight? [1: 66d9ef95c0]: 2016-02-14 17:07:48 +1100 Remove compat code for older Emacsen https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D66d9ef95c0f9407d= 2a6d26bcd7ed84a303294b53 --- a/lisp/gnus/gnus-int.el +++ b/lisp/gnus/gnus-int.el @@ -777,8 +777,7 @@ (defun gnus-request-accept-article (group &optional gnu= s-command-method last (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let ((gnus-command-method (or gnus-command-method (gnus-find-method-for-group group))) @@ -800,8 +799,7 @@ (defun gnus-request-replace-article (article group buff= er &optional no-encode) (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let* ((func (car (gnus-group-name-to-method group))) (result (funcall (intern (format "%s-request-replace-article" fun= c))