From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 281476DE0F4B for ; Mon, 22 Apr 2019 14:23:29 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.444 X-Spam-Level: X-Spam-Status: No, score=0.444 tagged_above=-999 required=5 tests=[AWL=-0.208, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h5CAxPrJxQEN for ; Mon, 22 Apr 2019 14:23:27 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 6D62F6DE0EED for ; Mon, 22 Apr 2019 14:23:26 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 5B02110008E; Tue, 23 Apr 2019 00:23:24 +0300 (EEST) From: Tomi Ollila To: Daniel Kahn Gillmor , Notmuch Mail Cc: 35370@debbugs.gnu.org Subject: Re: [PATCH] emacs: drop use of message-default-charset In-Reply-To: <20190422205116.10694-1-dkg@fifthhorseman.net> References: <831s1u6ofj.fsf@gnu.org> <20190422205116.10694-1-dkg@fifthhorseman.net> User-Agent: Notmuch/0.28.3+73~g5e2df9a (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 21:23:29 -0000 On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > In discussion with emacs upstream over on > https://debbugs.gnu.org/35370, it appears that we can just drop this > entirely and things should still work with emacs 25. I looked this a bit (well, quite a few minutes, rfc2047.el in emacs 24.3, 25.2 and 26.1), and while it is impossible to gain any real knowledge with such a shallow peek, I'd guess the following might be true: Since `mail-parse-charset` and `message-default-charset` are (were) both `nil` by default, this change does have any effect for users that never customized message-default-charset. If anyone did, now there is small chance that the line: "If nil, you might be asked to input the charset." (from message-default-charset docstring) can happen. In this context the change is IMO even more unlikely. So this change LGTM. Tomi > --- > emacs/notmuch-maildir-fcc.el | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el > index 1551e8b6..ae56bacd 100644 > --- a/emacs/notmuch-maildir-fcc.el > +++ b/emacs/notmuch-maildir-fcc.el > @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." > (message-encode-message-body) > (save-restriction > (message-narrow-to-headers) > - (let ((mail-parse-charset message-default-charset)) > - (mail-encode-encoded-word-buffer))) > + (mail-encode-encoded-word-buffer)) > (goto-char (point-min)) > (when (re-search-forward > (concat "^" (regexp-quote mail-header-separator) "$") > --=20 > 2.20.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch