From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 504066DE106E for ; Sun, 21 Apr 2019 07:41:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.027 X-Spam-Level: X-Spam-Status: No, score=-0.027 tagged_above=-999 required=5 tests=[AWL=-0.026, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zd1Q35IKkkWL for ; Sun, 21 Apr 2019 07:41:27 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 350906DE1061 for ; Sun, 21 Apr 2019 07:41:26 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hIDen-0004lk-Gw; Sun, 21 Apr 2019 10:41:25 -0400 Received: (nullmailer pid 26158 invoked by uid 1000); Sun, 21 Apr 2019 14:41:22 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: notmuch-emacs: avoiding deprecated message-default-charset In-Reply-To: <87tveswipo.fsf@fifthhorseman.net> References: <87tveswipo.fsf@fifthhorseman.net> Date: Sun, 21 Apr 2019 11:41:22 -0300 Message-ID: <874l6re7zh.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2019 14:41:28 -0000 Daniel Kahn Gillmor writes: > When i'm building notmuch in a debian environment with emacs > 1:26.1+1-3.2, i notice the following deprecation warnings: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-cha= rset=E2=80=99 is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > I'm not enough of an emacs guru to know the right way to avoid this > warning, but i'm hoping that someonen else can take a stab at it, since > extraneous warnings make it easier to ignore real problems. Good question. I looked at message.el in emacs master and it 1) Obsoletes message-default-charset as in 26.1 2) Still uses it in exactly the construction we do. I'm not sure if it's exactly a reportable bug in emacs, but it is a bit annoying. There is a variable byte-compile-not-obsolete-vars that (probably) can be used to suppress that warning, but it's not clear that's a good idea (we currently do something similar for Xapian obsolescence warnings that we can't fix). d