From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 4396B6DE1081 for ; Mon, 22 Apr 2019 13:52:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.147 X-Spam-Level: X-Spam-Status: No, score=-0.147 tagged_above=-999 required=5 tests=[AWL=0.054, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W7vRwFAaewFG for ; Mon, 22 Apr 2019 13:52:13 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id B13B16DE106E for ; Mon, 22 Apr 2019 13:52:08 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=VGp4nf8mqj2gqe35opnX7656r0cbxbNMoWiyK2stPOHR6ccQsBfLWuSq ydy8WDJ8ICqKv1uzTwgXUh8ZVB7YBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=fRFdRKG8JouJY3VvYaZXGoSaxwngCIciUbmNnuuPOIi8VywX4UwXXuDv BqlS2Kb9M5PTSsuVGeI9w2A3nJlBgloUvRNkA7rbyX2sBw0CyIhARa/kBD 588PT94+6YGnMUqrPqr+L08cZstJctEqRD6siaowCI57axZkDR9IpDLMsN utMkO9w+5xoJmk2pdB27z0sedju8EUIOLoiuz1N7By8h3ZAqkyogIutCtH 78XFcCOY5PvfQuk0bhY7RrFyHaIspUvbahh1azcbIcLZtqMnF0PBOsidun AjObSKlheR+7V8nZXXoUp1kaegTio6MIIH+5UNLymQhSZBmVWvL7Mg== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 625BBF99D; Mon, 22 Apr 2019 16:51:23 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id B89CC20103; Mon, 22 Apr 2019 16:51:16 -0400 (EDT) From: Daniel Kahn Gillmor To: Notmuch Mail Cc: 35370@debbugs.gnu.org Subject: [PATCH] emacs: drop use of message-default-charset Date: Mon, 22 Apr 2019 16:51:16 -0400 Message-Id: <20190422205116.10694-1-dkg@fifthhorseman.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <831s1u6ofj.fsf@gnu.org> References: <831s1u6ofj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 20:52:14 -0000 Apparently, message-default-charset is deprecated, which causes the following warning messages during the build: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset comes from the language environment In discussion with emacs upstream over on https://debbugs.gnu.org/35370, it appears that we can just drop this entirely and things should still work with emacs 25. --- emacs/notmuch-maildir-fcc.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 1551e8b6..ae56bacd 100644 --- a/emacs/notmuch-maildir-fcc.el +++ b/emacs/notmuch-maildir-fcc.el @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." (message-encode-message-body) (save-restriction (message-narrow-to-headers) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-min)) (when (re-search-forward (concat "^" (regexp-quote mail-header-separator) "$") -- 2.20.1