all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55673@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'.
Date: Fri, 27 May 2022 14:40:27 +0200	[thread overview]
Message-ID: <CAJ3okZ2RLDNYS+XzBfaaDEf5_uMW+3dT7OUMfWLV4to_0gsFRQ@mail.gmail.com> (raw)
In-Reply-To: <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be>

Hi Maxime,

On Fri, 27 May 2022 at 13:49, Maxime Devos <maximedevos@telenet.be> wrote:

> These old 4 bytes could be the ASCII representation of
>
>   "foo
>
> .  Then, when 'read' is run (after rebooting), it sees an incomplete
> string "foo, so it fails.

The question is how would 'read' fail or what would 'read' return?
For instance, the patch works for these cases:

 - empty file
 - non-integer

Now, if you are able to generate an incomplete file (from an integer
or whatever) against the patch fails, then we can examine.  However, I
miss what would be the difference between this incomplete file and,
let say, this case:

     echo -n -e \\x12 > ~/.cache/guix/inferiors/last-expiry-cleanup

handled by the patch.


Cheers,
simon




  reply	other threads:[~2022-05-27 12:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  8:25 [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' zimoun
2022-05-27  9:54 ` Maxime Devos
2022-05-27 10:28   ` zimoun
2022-05-27 11:12     ` Maxime Devos
2022-05-27 11:39       ` zimoun
2022-05-27 11:49         ` Maxime Devos
2022-05-27 12:40           ` zimoun [this message]
2022-05-27 13:04             ` Maxime Devos
2022-05-27 13:23               ` zimoun
2022-05-27 13:30                 ` zimoun
2022-05-27 14:02                 ` Maxime Devos
2022-05-27 16:19                   ` zimoun
2022-05-27 17:23                     ` Maxime Devos
2022-05-27 11:17     ` Maxime Devos
2022-05-27 11:24       ` zimoun
2022-05-27 11:40         ` Maxime Devos
2022-05-27 15:46 ` [bug#55673] [PATCH v2] " zimoun
2022-05-27 17:29   ` Maxime Devos
2022-05-30 13:09     ` zimoun
2022-05-30 13:07 ` [bug#55673] [PATCH v3] cache: Catch invalid 'last-expiry-cleanup' zimoun
2022-06-04 10:11   ` bug#55673: [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3okZ2RLDNYS+XzBfaaDEf5_uMW+3dT7OUMfWLV4to_0gsFRQ@mail.gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=55673@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.