From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 55673@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'.
Date: Fri, 27 May 2022 15:04:47 +0200 [thread overview]
Message-ID: <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> (raw)
In-Reply-To: <CAJ3okZ2RLDNYS+XzBfaaDEf5_uMW+3dT7OUMfWLV4to_0gsFRQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1181 bytes --]
zimoun schreef op vr 27-05-2022 om 14:40 [+0200]:
> > These old 4 bytes could be the ASCII representation of
> >
> > "foo
> >
> > . Then, when 'read' is run (after rebooting), it sees an
> > incomplete
> > string "foo, so it fails.
>
> The question is how would 'read' fail or what would 'read' return?
> For instance, the patch works for these cases:
>
> - empty file
> - non-integer
>
> Now, if you are able to generate an incomplete file (from an integer
> or whatever) against the patch fails, then we can examine. However,
> I
> miss what would be the difference between this incomplete file and,
> let say, this case:
>
> echo -n -e \\x12 > ~/.cache/guix/inferiors/last-expiry-cleanup
>
> handled by the patch.
The incomplete file is:
"foo
as mentioned previously. Here's how it fails:
scheme@(guile-user)> (call-with-input-file "a" read)
ice-9/boot-9.scm:1669:16: In procedure raise-exception:
In procedure scm_lreadr: a:2:1: end of file in string constant
The difference is that ^R is interpreted as a symbol, whereas "foo
cannot be interpreted as anything at all by 'read'.
Greetings,
Maxime.
[-- Attachment #1.2: a --]
[-- Type: text/plain, Size: 4 bytes --]
"foo
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-05-27 13:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:25 [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' zimoun
2022-05-27 9:54 ` Maxime Devos
2022-05-27 10:28 ` zimoun
2022-05-27 11:12 ` Maxime Devos
2022-05-27 11:39 ` zimoun
2022-05-27 11:49 ` Maxime Devos
2022-05-27 12:40 ` zimoun
2022-05-27 13:04 ` Maxime Devos [this message]
2022-05-27 13:23 ` zimoun
2022-05-27 13:30 ` zimoun
2022-05-27 14:02 ` Maxime Devos
2022-05-27 16:19 ` zimoun
2022-05-27 17:23 ` Maxime Devos
2022-05-27 11:17 ` Maxime Devos
2022-05-27 11:24 ` zimoun
2022-05-27 11:40 ` Maxime Devos
2022-05-27 15:46 ` [bug#55673] [PATCH v2] " zimoun
2022-05-27 17:29 ` Maxime Devos
2022-05-30 13:09 ` zimoun
2022-05-30 13:07 ` [bug#55673] [PATCH v3] cache: Catch invalid 'last-expiry-cleanup' zimoun
2022-06-04 10:11 ` bug#55673: [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55673@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.