From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>, 55673@debbugs.gnu.org
Cc: ludo@gnu.org
Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'.
Date: Fri, 27 May 2022 11:54:08 +0200 [thread overview]
Message-ID: <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> (raw)
In-Reply-To: <20220527082519.501697-1-zimon.toutoune@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
zimoun schreef op vr 27-05-2022 om 10:25 [+0200]:
> (catch 'system-error
> (lambda ()
> - (call-with-input-file expiry-file read))
> + (match (call-with-input-file expiry-file read)
> + ((? integer? date) date)
> + (_ 0)))
It might be possible to end up wit hsomething more bogus on some file
system, it's possible to end up with something even more boguse (e.g.,
"unterminated-string), which 'read' doesn't understand. I suggest
using 'get-string-all' + 'number->string'.
For completeness, a comment like
;; Handle the 'write' below being interrupted before the write
;; could complete (e.g. with C-c) and handle file system crashes
;; causing empty files or corrupted contents.
and a regression test in tets/cache.scm would be nice.
Also, I'd switch the catch and the (match ...) because 'read' and
integer? shouldn't raise any 'system-error'.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-05-27 9:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:25 [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' zimoun
2022-05-27 9:54 ` Maxime Devos [this message]
2022-05-27 10:28 ` zimoun
2022-05-27 11:12 ` Maxime Devos
2022-05-27 11:39 ` zimoun
2022-05-27 11:49 ` Maxime Devos
2022-05-27 12:40 ` zimoun
2022-05-27 13:04 ` Maxime Devos
2022-05-27 13:23 ` zimoun
2022-05-27 13:30 ` zimoun
2022-05-27 14:02 ` Maxime Devos
2022-05-27 16:19 ` zimoun
2022-05-27 17:23 ` Maxime Devos
2022-05-27 11:17 ` Maxime Devos
2022-05-27 11:24 ` zimoun
2022-05-27 11:40 ` Maxime Devos
2022-05-27 15:46 ` [bug#55673] [PATCH v2] " zimoun
2022-05-27 17:29 ` Maxime Devos
2022-05-30 13:09 ` zimoun
2022-05-30 13:07 ` [bug#55673] [PATCH v3] cache: Catch invalid 'last-expiry-cleanup' zimoun
2022-06-04 10:11 ` bug#55673: [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55673@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.