From: zimoun <zimon.toutoune@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55673@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'.
Date: Fri, 27 May 2022 13:39:19 +0200 [thread overview]
Message-ID: <CAJ3okZ1TQTPiNMkei1vYy_GixUtUh+NVsbpjb=qJq-Z7UnDHQA@mail.gmail.com> (raw)
In-Reply-To: <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be>
On Fri, 27 May 2022 at 13:12, Maxime Devos <maximedevos@telenet.be> wrote:
> But what if the computer crashes while the file is being made, and due
> to file system details, when rebooted, you end up with a non-integer?
> E.g. "unterminated-string.
If the value returned by 'read' is a non-integer, then it is set to 0
by the 'match'.
--8<---------------cut here---------------start------------->8---
$ echo -n -e \\x00\\x01\\x02\\x03 > ~/.cache/guix/inferiors/last-expiry-cleanup
$ cat ~/.cache/guix/inferiors/last-expiry-cleanup
\0 [env]
$ ./pre-inst-env guix time-machine --commit=9d795fb -- help
1653651128[env]
--8<---------------cut here---------------end--------------->8---
The only case is when 'read' fails. Personally, I do not see how it
would be possible. If you have a concrete example, then we can
examine.
Cheers,
simon
next prev parent reply other threads:[~2022-05-27 11:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:25 [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' zimoun
2022-05-27 9:54 ` Maxime Devos
2022-05-27 10:28 ` zimoun
2022-05-27 11:12 ` Maxime Devos
2022-05-27 11:39 ` zimoun [this message]
2022-05-27 11:49 ` Maxime Devos
2022-05-27 12:40 ` zimoun
2022-05-27 13:04 ` Maxime Devos
2022-05-27 13:23 ` zimoun
2022-05-27 13:30 ` zimoun
2022-05-27 14:02 ` Maxime Devos
2022-05-27 16:19 ` zimoun
2022-05-27 17:23 ` Maxime Devos
2022-05-27 11:17 ` Maxime Devos
2022-05-27 11:24 ` zimoun
2022-05-27 11:40 ` Maxime Devos
2022-05-27 15:46 ` [bug#55673] [PATCH v2] " zimoun
2022-05-27 17:29 ` Maxime Devos
2022-05-30 13:09 ` zimoun
2022-05-30 13:07 ` [bug#55673] [PATCH v3] cache: Catch invalid 'last-expiry-cleanup' zimoun
2022-06-04 10:11 ` bug#55673: [PATCH] cache: Catch valid integer for 'last-expiry-cleanup' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ1TQTPiNMkei1vYy_GixUtUh+NVsbpjb=qJq-Z7UnDHQA@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=55673@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.