From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uJFOEvXGkGLUagAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 14:41:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kBYzEvXGkGIJJwEAauVa8A (envelope-from ) for ; Fri, 27 May 2022 14:41:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D88641689D for ; Fri, 27 May 2022 14:41:24 +0200 (CEST) Received: from localhost ([::1]:48342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuZHQ-0006hK-3q for larch@yhetil.org; Fri, 27 May 2022 08:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuZH4-0006fy-Q7 for guix-patches@gnu.org; Fri, 27 May 2022 08:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuZH4-0001E4-0Z for guix-patches@gnu.org; Fri, 27 May 2022 08:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuZH3-0001Ez-V1 for guix-patches@gnu.org; Fri, 27 May 2022 08:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 12:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.16536552464737 (code B ref 55673); Fri, 27 May 2022 12:41:01 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 12:40:46 +0000 Received: from localhost ([127.0.0.1]:33065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZGn-0001EL-QB for submit@debbugs.gnu.org; Fri, 27 May 2022 08:40:45 -0400 Received: from mail-pg1-f169.google.com ([209.85.215.169]:43840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZGm-0001E9-Mu for 55673@debbugs.gnu.org; Fri, 27 May 2022 08:40:45 -0400 Received: by mail-pg1-f169.google.com with SMTP id s68so3823565pgs.10 for <55673@debbugs.gnu.org>; Fri, 27 May 2022 05:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uwNk8mKy2kwCrfpBvpBZOg4ZyhZVP5A4Af0mTnmX734=; b=i6WXXURUkjgcZuAkJokqb33EtDvIbl3cDPjEpzUxlm9jqRncJGnAV2xCiXrK++Hvcx DCTqLuP8NxC4PHElV0SRqbhswzThO7B0+Tj5VRerI5s/s9c88rf/xx7rLXn+ERbmki0i uEo4H9rvNPW+poC9zTWBJ6H0ATa7lm5ETYjulZ1mfftpbuoognmGZ5VwhYUHXCgflj2L ItY/EEMPW/DZhgvb47AkJr+6e6cNculSUk5TbqkJrfmvc+vUj8/0ElGIbn0sV3Aw3iqs 39PR1NkYKS24vBpsMr27AlADjb9FNbi2GhXFZ8kWrl1xna50J1AweHZkKe/J6MrmVHSi qq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uwNk8mKy2kwCrfpBvpBZOg4ZyhZVP5A4Af0mTnmX734=; b=ajKxtTVd/xowRs2kLDn1NgRLTihVQ0f1/MeBKlSE3YOcBQJwgoZ7o0Jpg5SiDQWxq9 jh/wGdRLGlFzu0FhRylrzIm4DcHz66DzVIodthdZZNNbWbN7qgHdhLl3vEFfmurlIODZ fidmBaeej6K7+5C+mxVioSglIbbG0+f0dEn84H/5O1kRwmFi7NqsASubZ3edbU1ilcrY dBX/ENQN1s2FpbAlbbyEGj2Jwm9oBA7PUO2u825GqztkTEo8g3I1Huvc43tTc9+3Zrn3 /BFuZLabSJ1VNR1jp4YrAdMUiCpdhfijMd9UWb9oKTEtPBOWW4IbYyAoorl9t1uNhMqy mZLg== X-Gm-Message-State: AOAM533RwF7mRQSXSu0gmwx1PqmlYXUWxRoBsCgE/OttMsHNuEt9dgJe OmFaNjHmDkWK21VV/WCTF/K6qh7br8oXpgL/qG0= X-Google-Smtp-Source: ABdhPJxjmBIBG3iL9x2qMhUSp9QXe8HukxCrXVAvUToGtJyW2HkD8+yVyKQ4gywFTfINGN1/03n0tOvpoFmr98sYUCU= X-Received: by 2002:a63:144c:0:b0:3fa:6f09:a3e4 with SMTP id 12-20020a63144c000000b003fa6f09a3e4mr19871396pgu.102.1653655238891; Fri, 27 May 2022 05:40:38 -0700 (PDT) MIME-Version: 1.0 References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> In-Reply-To: <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> From: zimoun Date: Fri, 27 May 2022 14:40:27 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653655285; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=uwNk8mKy2kwCrfpBvpBZOg4ZyhZVP5A4Af0mTnmX734=; b=hQhzOUSasU2i0JluwnJedXbZ+HDR7SIdPKdjPBmmIQ7IruTOdQ74Sp+qtuOx33vIJyoutZ ZmxwqBREB0XlEUi1aDI5txem1nGWYQbE2GyhZxqgVgI5PbK6Xhl6PGivrEL3VcNkujaZfC RyIcxDz3p8hM09M3uC9Gd5j1WMA8uDe12o0vQ/lgWpm7oKHDKdefRXTqne8czINBTVfSB5 sf0GPmgnNY1aO6R9PyZNmLXqs5I6ZO/1Aa9azD2w+ZtTVr4uHBYp8kf5G/xFgo9qRtd9sY OEoERgtuY4Dg2aOECpbYwOELTs/MXYdFjtTYpIun44J43S2utUBKdrHCd/JLRw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653655285; a=rsa-sha256; cv=none; b=Se+u/wZyc26MS24ShihSYUMjnTSbuRusxGM/1XKWr+1Im8ua5if1eiv5K3sJ+JDklyxxZp CWlzzS7iAX5zJto7Xmf5Y1GqivA9p47dgMEm0EnuZd3m653TgCfLKDVclOYx8fdvwbLvUa 0672H07VKdAVMKOWx7MnUfyRfQS2rlz4uPYzrKs/2BnKi9stPdj4yMEe5EYjzC74ixpX3D FtvNQdoO4wMdGmb0DLKFTMIM8WiQjHv22jUM+I6F2uzbfuiDEkAlP74vHfSFsXjqLZaPfW G6R4SVv+rFtERw3cwLtTuyGh9Oy3oNZ3K6hcIz5+EbKRcqtZny0GTU9Dv/fVmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i6WXXURU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i6WXXURU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D88641689D X-Spam-Score: 5.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: c60q+7hoTON7 Hi Maxime, On Fri, 27 May 2022 at 13:49, Maxime Devos wrote: > These old 4 bytes could be the ASCII representation of > > "foo > > . Then, when 'read' is run (after rebooting), it sees an incomplete > string "foo, so it fails. The question is how would 'read' fail or what would 'read' return? For instance, the patch works for these cases: - empty file - non-integer Now, if you are able to generate an incomplete file (from an integer or whatever) against the patch fails, then we can examine. However, I miss what would be the difference between this incomplete file and, let say, this case: echo -n -e \\x12 > ~/.cache/guix/inferiors/last-expiry-cleanup handled by the patch. Cheers, simon