From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SHZgHW+5kGJbKgAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 13:43:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yMBeHW+5kGLHoAAA9RJhRA (envelope-from ) for ; Fri, 27 May 2022 13:43:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2ACCD288DA for ; Fri, 27 May 2022 13:43:43 +0200 (CEST) Received: from localhost ([::1]:39026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuYNa-0006DA-3b for larch@yhetil.org; Fri, 27 May 2022 07:43:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuYM7-0006CU-Jn for guix-patches@gnu.org; Fri, 27 May 2022 07:42:12 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuYK2-0002pT-Iq for guix-patches@gnu.org; Fri, 27 May 2022 07:40:07 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuYK2-0005uB-GE for guix-patches@gnu.org; Fri, 27 May 2022 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165365158122666 (code B ref 55673); Fri, 27 May 2022 11:40:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 11:39:41 +0000 Received: from localhost ([127.0.0.1]:32939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuYJg-0005tW-OL for submit@debbugs.gnu.org; Fri, 27 May 2022 07:39:40 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:36742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuYJd-0005tH-2V for 55673@debbugs.gnu.org; Fri, 27 May 2022 07:39:39 -0400 Received: by mail-pg1-f179.google.com with SMTP id h186so3729109pgc.3 for <55673@debbugs.gnu.org>; Fri, 27 May 2022 04:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WKL43uHFFu5f60mylrYS59xTUeiBL51IhIssdyTVHvo=; b=O0ycgTrrIqL0nj7mU7Arb3C+7ckA7zWF4KPUNn3hbDmojybx2o/rYwLeREsJeO8KRh KeWsf37aIrc/YFQYQ8nLOiSv4FmXNbKlfQsGfSQvltZYcFMTRGMbxiyDBa/N0BDa/CHD TowfIzM1PIHul7/eOXw3GWwtmDC8lgQjmXY8i1yzvLosIGa2WUuKulfYyIX1/cs63C+9 C/XIkcrF3AMfFVr15ChnVEq/HrMn4e6ByGb7PvjYoAdyr7cWn8uqbEwzcOGu6KJnVYfI /4Kz9oli9fBSkhkHF8KwL4dZeDpAsB3hcpwAw5ImEgYNZpkuulBIQacQ+5wY+oorCI7O TKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WKL43uHFFu5f60mylrYS59xTUeiBL51IhIssdyTVHvo=; b=XB99c3cvBkiDJmhNx6UOL1dowfrqIQ0/BE8egwPIarYVCG8p9JI27qgxd0nPNTjTec KP9zQ+J90FNUHrqFM7Bsk0NI14YRAF/JSlDg1Sb5F/0rGVJazkDLs9s3Pv4BYzqdP/OO gptwwesAvdPSFqFRrcJpiOBpSccED8hSi7MPeRcBvloF8LqPeqFG4zgu9p+deQtXynD6 vbccFqp03aW7Qilfy8sYSqAs4/a4UwhnCMp/rQ2qSsWeqreZZguSL4JcHDKE/FCYLOoV NVuw6zDLGNkjgewNXsoPbfJgR4QsymPnbd7ksXHB/iGxj5G0xauO8U2siq0GkRRl20KK BeWg== X-Gm-Message-State: AOAM5315xqUh9KDwINgho+9TaOPMxVtH5g13aHatkVCkjnxnr/BZe/8q 4djd5O1pJeXZCPiLPmRHkbjFsilL1Kdr+ltoUeM= X-Google-Smtp-Source: ABdhPJxx0U/ga7e7wixiiSTr5XZFEoImmsjbXrr37NCnDEPA51wIvUSN9V/BSgVV0Cf9R+B4sU9P/XeYcxu1xRDldJw= X-Received: by 2002:a65:5c48:0:b0:382:2c7:28e9 with SMTP id v8-20020a655c48000000b0038202c728e9mr37657107pgr.472.1653651571064; Fri, 27 May 2022 04:39:31 -0700 (PDT) MIME-Version: 1.0 References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> In-Reply-To: <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> From: zimoun Date: Fri, 27 May 2022 13:39:19 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653651823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WKL43uHFFu5f60mylrYS59xTUeiBL51IhIssdyTVHvo=; b=k2eqdBzLUoA3jEc7Qt/1/ftTBoiM3b+VelT3XLVJvA5PdDYeibg21WgLbwkQSE20WWUFmI xnxegBVfbTIf1xB2wDgSedjLBhqvO8Vi0Hv4b8KwpyboPfzv5PlPXaosfvqC0VGpJOHDqh h3xt+f3keIpWfKdGj3wxm5S4aod4WmFg1qOedYj1z8E5/lWZFcnbx7XXDtkfYQxiBpFgDw 0ho1uod1XPrvX/23fBjRyMT1qxjxwhc1rBRMq0jbIp+YtIpdE07YBbE8RBZbS1o3sbKDGQ 779rAI7zkLMH/0Mrdvb0KPjjAkF1/OAO6nQ6fN3+X0x3QcDW6KUC7Gr3wEybQQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653651823; a=rsa-sha256; cv=none; b=NdeBEOc6LIZajlcn9Z6r4lK86pOMBnfd6TCcOJqECxloWfW/CF2ROcniIH0zr6ADIP7l+G aOdXynEezjcAVD1eFenyqt3ozuEQFBWxqyfdw4lBbhsgfoN2dDZ48pLsyEVRy2oqhx3Az1 jyN4ThM6GSTi5S4Y1uRLNbv4hakDYt1SvrxwdjIEBcUu6WfoErLgPzMHUkFalYL2xQtfsQ jhlBXEjvX3ILyOmnIJ2LABYEarakNRGeRECJJToP1v29KIC0W+UBFd4WQLOXFaw3qQt5AH Gvg+yE44WgX1aod6D6p0MhfchachmbI/tjeZzVCEFO7QtB0Vcw69iV0bP/3s+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=O0ycgTrr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.55 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=O0ycgTrr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2ACCD288DA X-Spam-Score: 4.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: DzCvg8MXqw5+ On Fri, 27 May 2022 at 13:12, Maxime Devos wrote: > But what if the computer crashes while the file is being made, and due > to file system details, when rebooted, you end up with a non-integer? > E.g. "unterminated-string. If the value returned by 'read' is a non-integer, then it is set to 0 by the 'match'. --8<---------------cut here---------------start------------->8--- $ echo -n -e \\x00\\x01\\x02\\x03 > ~/.cache/guix/inferiors/last-expiry-cleanup $ cat ~/.cache/guix/inferiors/last-expiry-cleanup \0 [env] $ ./pre-inst-env guix time-machine --commit=9d795fb -- help 1653651128[env] --8<---------------cut here---------------end--------------->8--- The only case is when 'read' fails. Personally, I do not see how it would be possible. If you have a concrete example, then we can examine. Cheers, simon