* [bug#46313] [PATCH] gnu: Add chiaki.
@ 2021-02-05 3:17 Léo Le Bouter via Guix-patches via
2021-02-07 9:43 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Léo Le Bouter via Guix-patches via @ 2021-02-05 3:17 UTC (permalink / raw)
To: 46313; +Cc: Léo Le Bouter
* gnu/packages/games.scm (chiaki): New variable.
---
gnu/packages/games.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index e3e18bf09e..3d6ba05a39 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12178,3 +12178,42 @@ game FPS.")
implemented using ncurses user interface. An SDL graphical version is also
available.")
(license license:gpl3+)))
+
+(define-public chiaki
+ (package
+ (name "chiaki")
+ (version "2.1.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.sr.ht/~thestr4ng3r/chiaki")
+ (commit (string-append "v" version))
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1kjaahv80p040wicj1a4ac1j2zsg0dbbf60a9aapn45qlkq80h2n"))))
+ (build-system cmake-build-system)
+ (native-inputs
+ `(("python" ,python)
+ ("protobuf" ,protobuf)
+ ("pkg-config" ,pkg-config)
+ ("python-protobuf" ,python-protobuf)))
+ (inputs
+ `(("ffmpeg" ,ffmpeg)
+ ("opus" ,opus)
+ ("openssl" ,openssl)
+ ("libevdev" ,libevdev)
+ ("qtbase" ,qtbase)
+ ("qtmultimedia" ,qtmultimedia)
+ ("qtsvg" ,qtsvg)
+ ("sdl2" ,sdl2)))
+ (home-page "https://git.sr.ht/~thestr4ng3r/chiaki")
+ (synopsis "Free and Open Source PlayStation Remote Play Client")
+ (description "Chiaki is a Free and Open Source Software Client for
+PlayStation 4 and PlayStation 5 Remote Play.")
+ (license
+ (license:fsdg-compatible
+ "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
+ "AGPL-3.0-only-OpenSSL"))))
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#46313] [PATCH] gnu: Add chiaki.
2021-02-05 3:17 [bug#46313] [PATCH] gnu: Add chiaki Léo Le Bouter via Guix-patches via
@ 2021-02-07 9:43 ` Nicolas Goaziou
2021-02-07 16:57 ` Léo Le Bouter via Guix-patches via
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2021-02-07 9:43 UTC (permalink / raw)
To: Léo Le Bouter; +Cc: 46313
Hello,
Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/games.scm (chiaki): New variable.
Thank you. Some comments follow.
> + (recursive? #t)))
Do you know what sub-modules are being pulled? Could we unbundle them
instead?
> + (synopsis "Free and Open Source PlayStation Remote Play Client")
Please remove "Free" and "Open Source": everything is in Guix. Also,
synopsis should not use titlecase:
"PlayStation Remote Play client"
> + (description "Chiaki is a Free and Open Source Software Client for
> +PlayStation 4 and PlayStation 5 Remote Play.")
See above. Also, couldyou expound a bit the description?
> + (license
> + (license:fsdg-compatible
It should be fsf-free instead of fsdg-compatible.
> + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> + "AGPL-3.0-only-OpenSSL"))))
I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
but I wonder if Guix cares about the exception.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread* [bug#46313] [PATCH] gnu: Add chiaki.
2021-02-07 9:43 ` Nicolas Goaziou
@ 2021-02-07 16:57 ` Léo Le Bouter via Guix-patches via
0 siblings, 0 replies; 3+ messages in thread
From: Léo Le Bouter via Guix-patches via @ 2021-02-07 16:57 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 46313
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
On Sun, 2021-02-07 at 10:43 +0100, Nicolas Goaziou wrote:
> Hello,
Hello!
>
> Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/games.scm (chiaki): New variable.
>
> Thank you. Some comments follow.
>
> > + (recursive? #t)))
>
> Do you know what sub-modules are being pulled? Could we unbundle them
> instead?
There is gf-complete, jerasure and nanopb. Will have to look for
unbundling.
>
> > + (synopsis "Free and Open Source PlayStation Remote Play
> > Client")
>
> Please remove "Free" and "Open Source": everything is in Guix. Also,
> synopsis should not use titlecase:
>
> "PlayStation Remote Play client"
>
> > + (description "Chiaki is a Free and Open Source Software Client
> > for
> > +PlayStation 4 and PlayStation 5 Remote Play.")
>
> See above. Also, couldyou expound a bit the description?
>
Okay, merely copied the synopsis and description from the original
project.
> > + (license
> > + (license:fsdg-compatible
>
> It should be fsf-free instead of fsdg-compatible.
>
> > + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> > + "AGPL-3.0-only-OpenSSL"))))
>
The thing is, the FSF does not approve that particular variant of the
license with OpenSSL exception so that's why I only specified it is
compatible.
> I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
> but I wonder if Guix cares about the exception.
>
> Could you send an updated patch?
>
ASAP.
>
> Regards,
Thank you.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-07 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 3:17 [bug#46313] [PATCH] gnu: Add chiaki Léo Le Bouter via Guix-patches via
2021-02-07 9:43 ` Nicolas Goaziou
2021-02-07 16:57 ` Léo Le Bouter via Guix-patches via
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.