From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Uw3FF222H2C5dgAA0tVLHw (envelope-from ) for ; Sun, 07 Feb 2021 09:44:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id Og11E222H2DSWwAAB5/wlQ (envelope-from ) for ; Sun, 07 Feb 2021 09:44:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC7F19402BD for ; Sun, 7 Feb 2021 09:44:12 +0000 (UTC) Received: from localhost ([::1]:35278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8gbz-0003d0-KI for larch@yhetil.org; Sun, 07 Feb 2021 04:44:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8gbq-0003cu-CZ for guix-patches@gnu.org; Sun, 07 Feb 2021 04:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8gbq-0000Sl-5O for guix-patches@gnu.org; Sun, 07 Feb 2021 04:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8gbq-0002vb-3T for guix-patches@gnu.org; Sun, 07 Feb 2021 04:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46313] [PATCH] gnu: Add chiaki. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Feb 2021 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46313 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: 46313@debbugs.gnu.org Received: via spool by 46313-submit@debbugs.gnu.org id=B46313.161269103211231 (code B ref 46313); Sun, 07 Feb 2021 09:44:02 +0000 Received: (at 46313) by debbugs.gnu.org; 7 Feb 2021 09:43:52 +0000 Received: from localhost ([127.0.0.1]:46899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8gbg-0002v5-3T for submit@debbugs.gnu.org; Sun, 07 Feb 2021 04:43:52 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:34205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8gbd-0002uq-Ip for 46313@debbugs.gnu.org; Sun, 07 Feb 2021 04:43:50 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 555D9240003; Sun, 7 Feb 2021 09:43:42 +0000 (UTC) From: Nicolas Goaziou References: <20210205031731.27620-1-lle-bout@zaclys.net> Date: Sun, 07 Feb 2021 10:43:41 +0100 In-Reply-To: <20210205031731.27620-1-lle-bout@zaclys.net> ("=?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via"'s message of "Fri, 5 Feb 2021 04:17:31 +0100") Message-ID: <87eehsusaa.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CC7F19402BD X-Spam-Score: -2.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: W1g4h77X2qoF Hello, L=C3=A9o Le Bouter via Guix-patches via writes: > * gnu/packages/games.scm (chiaki): New variable. Thank you. Some comments follow. > + (recursive? #t))) Do you know what sub-modules are being pulled? Could we unbundle them instead? > + (synopsis "Free and Open Source PlayStation Remote Play Client") Please remove "Free" and "Open Source": everything is in Guix. Also, synopsis should not use titlecase: "PlayStation Remote Play client" > + (description "Chiaki is a Free and Open Source Software Client for > +PlayStation 4 and PlayStation 5 Remote Play.") See above. Also, couldyou expound a bit the description? > + (license > + (license:fsdg-compatible It should be fsf-free instead of fsdg-compatible. > + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt" > + "AGPL-3.0-only-OpenSSL")))) I think the correct string would be "AGPL-3.0 WITH OpenSSL exception" but I wonder if Guix cares about the exception. Could you send an updated patch? Regards, --=20 Nicolas Goaziou