From: "Léo Le Bouter via Guix-patches via" <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 46313@debbugs.gnu.org
Subject: [bug#46313] [PATCH] gnu: Add chiaki.
Date: Sun, 07 Feb 2021 17:57:11 +0100 [thread overview]
Message-ID: <94473bccc8667f30694bd17a6cdf99eac0ca145b.camel@zaclys.net> (raw)
In-Reply-To: <87eehsusaa.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
On Sun, 2021-02-07 at 10:43 +0100, Nicolas Goaziou wrote:
> Hello,
Hello!
>
> Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/games.scm (chiaki): New variable.
>
> Thank you. Some comments follow.
>
> > + (recursive? #t)))
>
> Do you know what sub-modules are being pulled? Could we unbundle them
> instead?
There is gf-complete, jerasure and nanopb. Will have to look for
unbundling.
>
> > + (synopsis "Free and Open Source PlayStation Remote Play
> > Client")
>
> Please remove "Free" and "Open Source": everything is in Guix. Also,
> synopsis should not use titlecase:
>
> "PlayStation Remote Play client"
>
> > + (description "Chiaki is a Free and Open Source Software Client
> > for
> > +PlayStation 4 and PlayStation 5 Remote Play.")
>
> See above. Also, couldyou expound a bit the description?
>
Okay, merely copied the synopsis and description from the original
project.
> > + (license
> > + (license:fsdg-compatible
>
> It should be fsf-free instead of fsdg-compatible.
>
> > + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> > + "AGPL-3.0-only-OpenSSL"))))
>
The thing is, the FSF does not approve that particular variant of the
license with OpenSSL exception so that's why I only specified it is
compatible.
> I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
> but I wonder if Guix cares about the exception.
>
> Could you send an updated patch?
>
ASAP.
>
> Regards,
Thank you.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-02-07 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 3:17 [bug#46313] [PATCH] gnu: Add chiaki Léo Le Bouter via Guix-patches via
2021-02-07 9:43 ` Nicolas Goaziou
2021-02-07 16:57 ` Léo Le Bouter via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94473bccc8667f30694bd17a6cdf99eac0ca145b.camel@zaclys.net \
--to=guix-patches@gnu.org \
--cc=46313@debbugs.gnu.org \
--cc=lle-bout@zaclys.net \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.