From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Léo Le Bouter" <lle-bout@zaclys.net>
Cc: 46313@debbugs.gnu.org
Subject: [bug#46313] [PATCH] gnu: Add chiaki.
Date: Sun, 07 Feb 2021 10:43:41 +0100 [thread overview]
Message-ID: <87eehsusaa.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210205031731.27620-1-lle-bout@zaclys.net> ("Léo Le Bouter via Guix-patches via"'s message of "Fri, 5 Feb 2021 04:17:31 +0100")
Hello,
Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/games.scm (chiaki): New variable.
Thank you. Some comments follow.
> + (recursive? #t)))
Do you know what sub-modules are being pulled? Could we unbundle them
instead?
> + (synopsis "Free and Open Source PlayStation Remote Play Client")
Please remove "Free" and "Open Source": everything is in Guix. Also,
synopsis should not use titlecase:
"PlayStation Remote Play client"
> + (description "Chiaki is a Free and Open Source Software Client for
> +PlayStation 4 and PlayStation 5 Remote Play.")
See above. Also, couldyou expound a bit the description?
> + (license
> + (license:fsdg-compatible
It should be fsf-free instead of fsdg-compatible.
> + "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> + "AGPL-3.0-only-OpenSSL"))))
I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
but I wonder if Guix cares about the exception.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-02-07 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 3:17 [bug#46313] [PATCH] gnu: Add chiaki Léo Le Bouter via Guix-patches via
2021-02-07 9:43 ` Nicolas Goaziou [this message]
2021-02-07 16:57 ` Léo Le Bouter via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eehsusaa.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=46313@debbugs.gnu.org \
--cc=lle-bout@zaclys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.