From: Andrew Tropin <andrew@trop.in>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org
Subject: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega.
Date: Fri, 10 Dec 2021 10:40:24 +0300 [thread overview]
Message-ID: <878rwsj4bb.fsf@trop.in> (raw)
In-Reply-To: <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
On 2021-12-09 20:39, Liliana Marie Prikler wrote:
> Hi,
>
> note to self: I'm not trying to build tdlib again. Last build was not
> finished after almost a day and power went out so I don't even know
> whether it succeeded after I went to work or not.
Ouch, IIRC it took a few dozens of minutes for my laptop. Do you use
underpowered hardware or something was wrong with compilation process?
>
> Anyway,
>
>> +-(defcustom telega-server-command "telega-server"
>> ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@"
> [...]
>> - (substitute* "telega-server.el"
>> + (substitute* "telega-customize.el"
>> (("@TELEGA_SERVER_BIN@")
>> (string-append (assoc-ref inputs "emacs-telega-
>> server")
>> "/bin/telega-server")))
>>
> I know this has existed before your patch, but I'm pretty sure we have
> emacs-based routines that could make this substitution in one go.
Do you mean emacs-substitute-sexps from (guix build emacs-utils) ?
> If you're interested in further janitor work, you could do this either
> on master, or you could do something in terms of (search-input-file)
> on c- u-f.
>
> Other than that LGTM on a quick glance.
> Cheers
>
Let's keep it as it is right now, probably I'll be updating this package
later again and will refactor it.
Also, I'll need to update emacs-telega package to include add-pkg-file
phase if the patch will be merged, so I'll cleanup the other stuff
around it.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-12-10 7:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:27 [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega Andrew Tropin
2021-12-09 8:27 ` Nicolas Goaziou
2021-12-09 8:43 ` Evgeny Zajcev
2021-12-09 11:43 ` Andrew Tropin
2021-12-09 15:34 ` Andrew Tropin
2021-12-09 19:39 ` Liliana Marie Prikler
2021-12-10 7:40 ` Andrew Tropin [this message]
2021-12-10 19:31 ` Liliana Marie Prikler
2021-12-11 15:13 ` bug#52371: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rwsj4bb.fsf@trop.in \
--to=andrew@trop.in \
--cc=52371@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=mail@nicolasgoaziou.fr \
--cc=zevlg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.