From: Andrew Tropin <andrew@trop.in>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org
Subject: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega.
Date: Thu, 09 Dec 2021 14:43:39 +0300 [thread overview]
Message-ID: <87lf0udmvo.fsf@trop.in> (raw)
In-Reply-To: <87bl1qtc7y.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]
On 2021-12-09 09:27, Nicolas Goaziou wrote:
> Hello,
>
> Andrew Tropin <andrew@trop.in> writes:
>
>> tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no
>> 1.7.9 tag in upstream repo, but the version is present in source code.
>> https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9/CMakeLists.txt#L9
>>
>> emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib
>> version doesn't work anymore, Evgeny (author of telega.el) suggest to
>> use telega version from master branch. I used 0.7.15 tag (closest tag
>> to the version in master branch I found) + revision + commit hash.
>>
>> Without those updates tdlib and all clients based on it doesn't work,
>> it's quite unfortunate behavior from Telegram developers, IMHO of
>> course, but it's necessary to update to non-tagged versions to get it
>> work again.
>
> Thank you.
>
> Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib.
> It corresponds to release 1.7.10 so you don't have to use revision and
> commit binding.
Will do.
>
> Also, could you send this in two separate patches, and provide a proper
> commit message, specifying new patch files and registering them in
> local.mk?
Not sure what you mean, there are already two inline patches with proper
commit messages (at least I hope it's proper :).
The patches for telegram.el are not new, so they already registered in
local.mk, I just updated the content to match current source code.
>
> Also, you can remove trailing #t from phases.
>
> Could you send an updated patch?
>
> Regards,
Yep.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-12-09 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:27 [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega Andrew Tropin
2021-12-09 8:27 ` Nicolas Goaziou
2021-12-09 8:43 ` Evgeny Zajcev
2021-12-09 11:43 ` Andrew Tropin [this message]
2021-12-09 15:34 ` Andrew Tropin
2021-12-09 19:39 ` Liliana Marie Prikler
2021-12-10 7:40 ` Andrew Tropin
2021-12-10 19:31 ` Liliana Marie Prikler
2021-12-11 15:13 ` bug#52371: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf0udmvo.fsf@trop.in \
--to=andrew@trop.in \
--cc=52371@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=zevlg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.