all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Andrew Tropin <andrew@trop.in>, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org
Subject: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega.
Date: Thu, 09 Dec 2021 20:39:36 +0100	[thread overview]
Message-ID: <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> (raw)
In-Reply-To: <87k0gdg5b9.fsf@trop.in>

Hi,

note to self: I'm not trying to build tdlib again.  Last build was not
finished after almost a day and power went out so I don't even know
whether it succeeded after I went to work or not.

Anyway,

> +-(defcustom telega-server-command "telega-server"
> ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@"
[...]
> -             (substitute* "telega-server.el"
> +             (substitute* "telega-customize.el"
>                 (("@TELEGA_SERVER_BIN@")
>                  (string-append (assoc-ref inputs "emacs-telega-
> server")
>                                 "/bin/telega-server")))
> 
I know this has existed before your patch, but I'm pretty sure we have
emacs-based routines that could make this substitution in one go.  If
you're interested in further janitor work, you could do this either on
master, or you could do something in terms of (search-input-file) on c-
u-f.

Other than that LGTM on a quick glance.
Cheers





  reply	other threads:[~2021-12-09 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08  9:27 [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega Andrew Tropin
2021-12-09  8:27 ` Nicolas Goaziou
2021-12-09  8:43   ` Evgeny Zajcev
2021-12-09 11:43   ` Andrew Tropin
2021-12-09 15:34   ` Andrew Tropin
2021-12-09 19:39     ` Liliana Marie Prikler [this message]
2021-12-10  7:40       ` Andrew Tropin
2021-12-10 19:31         ` Liliana Marie Prikler
2021-12-11 15:13         ` bug#52371: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=52371@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=mail@nicolasgoaziou.fr \
    --cc=zevlg@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.