* [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
@ 2018-11-08 22:27 Kei Kebreau
2018-11-16 21:44 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2018-11-08 22:27 UTC (permalink / raw)
To: 33322; +Cc: Kei Kebreau
* gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
---
gnu/packages/maths.scm | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 808ab5345..389343051 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2716,6 +2716,18 @@ to BMP, JPEG or PNG image formats.")
(lambda _
(chmod "src/maxima" #o555)
#t))
+ (replace 'check
+ (lambda _
+ ;; This is derived from the testing code in the "debian/rules" file
+ ;; of Debian's Maxima package.
+ ;; If Maxima can successfully run this, the binary to be installed
+ ;; should be fine.
+ (zero?
+ (system
+ (string-append "./maxima-local "
+ "--lisp=gcl "
+ "--batch-string=\"run_testsuite();\" "
+ "| grep -q \"No unexpected errors found\"")))))
;; Make sure the doc and emacs files are found in the
;; standard location. Also configure maxima to find gnuplot
;; without having it on the PATH.
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
2018-11-08 22:27 [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64 Kei Kebreau
@ 2018-11-16 21:44 ` Ludovic Courtès
2018-11-18 17:03 ` bug#33322: " Kei Kebreau
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2018-11-16 21:44 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 33322
Hello,
Kei Kebreau <kkebreau@posteo.net> skribis:
> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
[...]
> + ;; This is derived from the testing code in the "debian/rules" file
> + ;; of Debian's Maxima package.
> + ;; If Maxima can successfully run this, the binary to be installed
> + ;; should be fine.
> + (zero?
> + (system
> + (string-append "./maxima-local "
> + "--lisp=gcl "
> + "--batch-string=\"run_testsuite();\" "
> + "| grep -q \"No unexpected errors found\"")))))
So the exit code without grep isn’t good enough, right?
If it has to be this way, so be it!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#33322: [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
2018-11-16 21:44 ` Ludovic Courtès
@ 2018-11-18 17:03 ` Kei Kebreau
0 siblings, 0 replies; 3+ messages in thread
From: Kei Kebreau @ 2018-11-18 17:03 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 33322-done
ludo@gnu.org (Ludovic Courtès) writes:
> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
>
> [...]
>
>> + ;; This is derived from the testing code in the "debian/rules"
>> file
>> + ;; of Debian's Maxima package.
>> + ;; If Maxima can successfully run this, the binary to be installed
>> + ;; should be fine.
>> + (zero?
>> + (system
>> + (string-append "./maxima-local "
>> + "--lisp=gcl "
>> + "--batch-string=\"run_testsuite();\" "
>> + "| grep -q \"No unexpected errors found\"")))))
>
> So the exit code without grep isn’t good enough, right?
>
> If it has to be this way, so be it!
>
Yes, because I think that Maxima returns successfully as long as it
exits without the underlying Lisp implementation crashing.
> Thanks,
> Ludo’.
Thank you for the review!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-18 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 22:27 [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64 Kei Kebreau
2018-11-16 21:44 ` Ludovic Courtès
2018-11-18 17:03 ` bug#33322: " Kei Kebreau
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.