From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35283)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gNlwB-0007Z0-QH
	for guix-patches@gnu.org; Fri, 16 Nov 2018 16:46:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gNlwA-0003bk-L2
	for guix-patches@gnu.org; Fri, 16 Nov 2018 16:46:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52599)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gNlwA-0003YS-8h
	for guix-patches@gnu.org; Fri, 16 Nov 2018 16:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gNlwA-0008OX-3c
	for guix-patches@gnu.org; Fri, 16 Nov 2018 16:46:02 -0500
Subject: [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Resent-Message-ID: <handler.33322.B33322.154240470432195@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181108222717.10007-1-kkebreau@posteo.net>
Date: Fri, 16 Nov 2018 22:44:50 +0100
In-Reply-To: <20181108222717.10007-1-kkebreau@posteo.net> (Kei Kebreau's
	message of "Thu, 8 Nov 2018 17:27:17 -0500")
Message-ID: <871s7ksnn1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 33322@debbugs.gnu.org

Hello,

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.

[...]

> +             ;; This is derived from the testing code in the "debian/rul=
es" file
> +             ;; of Debian's Maxima package.
> +             ;; If Maxima can successfully run this, the binary to be in=
stalled
> +             ;; should be fine.
> +             (zero?
> +              (system
> +               (string-append "./maxima-local "
> +                              "--lisp=3Dgcl "
> +                              "--batch-string=3D\"run_testsuite();\" "
> +                              "| grep -q \"No unexpected errors found\""=
)))))

So the exit code without grep isn=E2=80=99t good enough, right?

If it has to be this way, so be it!

Thanks,
Ludo=E2=80=99.