all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33322-done@debbugs.gnu.org
Subject: bug#33322: [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Date: Sun, 18 Nov 2018 12:03:16 -0500	[thread overview]
Message-ID: <87wopafhd7.fsf@posteo.net> (raw)
In-Reply-To: <871s7ksnn1.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 16 Nov 2018 22:44:50 +0100")

ludo@gnu.org (Ludovic Courtès) writes:

> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
>
> [...]
>
>> + ;; This is derived from the testing code in the "debian/rules"
>> file
>> +             ;; of Debian's Maxima package.
>> + ;; If Maxima can successfully run this, the binary to be installed
>> +             ;; should be fine.
>> +             (zero?
>> +              (system
>> +               (string-append "./maxima-local "
>> +                              "--lisp=gcl "
>> +                              "--batch-string=\"run_testsuite();\" "
>> +                              "| grep -q \"No unexpected errors found\"")))))
>
> So the exit code without grep isn’t good enough, right?
>
> If it has to be this way, so be it!
>

Yes, because I think that Maxima returns successfully as long as it
exits without the underlying Lisp implementation crashing.

> Thanks,
> Ludo’.

Thank you for the review!

      reply	other threads:[~2018-11-18 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 22:27 [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64 Kei Kebreau
2018-11-16 21:44 ` Ludovic Courtès
2018-11-18 17:03   ` Kei Kebreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wopafhd7.fsf@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=33322-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.