From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOQUQ-0001br-0C
	for guix-patches@gnu.org; Sun, 18 Nov 2018 12:04:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOQUM-0003RN-Rf
	for guix-patches@gnu.org; Sun, 18 Nov 2018 12:04:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:55071)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gOQUM-0003RB-OV
	for guix-patches@gnu.org; Sun, 18 Nov 2018 12:04:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOQUM-0005r8-Cz
	for guix-patches@gnu.org; Sun, 18 Nov 2018 12:04:02 -0500
Subject: bug#33322: [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.33322.D33322.154256060722464.done@debbugs.gnu.org>
From: Kei Kebreau <kkebreau@posteo.net>
References: <20181108222717.10007-1-kkebreau@posteo.net>
	<871s7ksnn1.fsf@gnu.org>
Date: Sun, 18 Nov 2018 12:03:16 -0500
In-Reply-To: <871s7ksnn1.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 16 Nov 2018 22:44:50 +0100")
Message-ID: <87wopafhd7.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 33322-done@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
>
> [...]
>
>> + ;; This is derived from the testing code in the "debian/rules"
>> file
>> +             ;; of Debian's Maxima package.
>> + ;; If Maxima can successfully run this, the binary to be installed
>> +             ;; should be fine.
>> +             (zero?
>> +              (system
>> +               (string-append "./maxima-local "
>> +                              "--lisp=3Dgcl "
>> +                              "--batch-string=3D\"run_testsuite();\" "
>> +                              "| grep -q \"No unexpected errors found\"=
")))))
>
> So the exit code without grep isn=E2=80=99t good enough, right?
>
> If it has to be this way, so be it!
>

Yes, because I think that Maxima returns successfully as long as it
exits without the underlying Lisp implementation crashing.

> Thanks,
> Ludo=E2=80=99.

Thank you for the review!