all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: nee <nee@cock.li>
To: Arun Isaac <arunisaac@systemreboot.net>, 26500@debbugs.gnu.org
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Mon, 17 Apr 2017 06:45:49 +0200	[thread overview]
Message-ID: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li> (raw)
In-Reply-To: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com>

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

Am 16.04.2017 um 10:53 schrieb Arun Isaac:
> Instead of mentioning p7zip, unrar and mupdf in the description, it
> would be better if we could make them inputs and patch all references to
> the executables in the source with their absolute paths. Could you try this?
I could try that, but mupdf is a pretty heavy dependency. guix size says
it's self-size is 208MiB and total-size is 491MiB.
I personally never needed it with mcomix, so I like that it is optional.
Is there some way to define a package with optional inputs?

For now I'm appending my WIP that should address your previous remarks.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-mcomix.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-mcomix.patch", Size: 2650 bytes --]

From 493a6e0c1c5dd9ef6b454b31be9b80646f201fb4 Mon Sep 17 00:00:00 2001
From: nee <nee.git@cock.li>
Date: Fri, 14 Apr 2017 19:09:40 +0200
Subject: [PATCH] gnu: Add mcomix.

* gnu/packages/image-viewers.scm (mcomix): New variable.
---
 gnu/packages/image-viewers.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 830ce10ea..bfcad99f1 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2017 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2017 nee <nee-git@hidamari.blue>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,6 +29,7 @@
   #:use-module (guix packages)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system python)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages base)
@@ -46,6 +48,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages))
 
 (define-public feh
@@ -360,3 +363,30 @@ imaging.  It supports several HDR and LDR image formats, and it can:
 @item Copy EXIF data between sets of images.
 @end itemize\n")
     (license license:gpl2+)))
+
+(define-public mcomix
+  (package
+    (name "mcomix")
+    (version "1.2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/mcomix/MComix-" version
+                           "/mcomix-" version ".tar.bz2"))
+       (sha256
+        (base32
+         "0fzsf9pklhfs1rzwzj64c0v30b74nk94p93h371rpg45qnfiahvy"))))
+    (build-system python-build-system)
+    ;; Python 2.5 or newer (Python 3 and up is not supported)
+    (arguments `(#:python ,python-2))
+    (inputs `(("python2-pygtk" ,python2-pygtk)
+              ("python2-pillow" ,python2-pillow)))
+    (home-page "https://sourceforge.net/p/mcomix/wiki/Home/")
+    (synopsis "Image viewer for comics")
+    (description "MComix is a customizable image viewer that specializes as
+a comic and manga reader.  It supports a variety of container formats
+including CBR, CBZ, CB7, CBT, LHA.
+For 7z support install the p7zip package.
+For rar support install the unrar package.
+For pdf support install the mupdf package.")
+    (license license:gpl2+)))
-- 
2.12.2


  reply	other threads:[~2017-04-17  2:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 17:50 bug#26500: [PATCH] gnu: Add mcomix nee
2017-04-15  8:36 ` Arun Isaac
2017-04-15  9:09   ` ng0
2017-04-16  8:53     ` Arun Isaac
2017-04-17  4:45       ` nee [this message]
2017-04-17 19:21         ` Arun Isaac
2017-04-18 22:09           ` nee
2017-04-19 15:53             ` Arun Isaac
2017-04-19 19:54               ` ng0
2017-04-21  9:00               ` Ludovic Courtès
2017-04-21 17:57                 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e116405-23c7-b059-e4af-9cee0893ae57@cock.li \
    --to=nee@cock.li \
    --cc=26500@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.