From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czwg5-0006I9-5l for guix-patches@gnu.org; Sun, 16 Apr 2017 22:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czwg1-00032l-7W for guix-patches@gnu.org; Sun, 16 Apr 2017 22:46:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czwfz-00031X-Cq for guix-patches@gnu.org; Sun, 16 Apr 2017 22:46:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czwfy-000833-9a for guix-patches@gnu.org; Sun, 16 Apr 2017 22:46:03 -0400 Subject: bug#26500: [PATCH] gnu: Add mcomix. Resent-Message-ID: References: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> <20170415090932.ed7dzowf6s5cwln5@abyayala> <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> From: nee Message-ID: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li> Date: Mon, 17 Apr 2017 06:45:49 +0200 MIME-Version: 1.0 In-Reply-To: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> Content-Type: multipart/mixed; boundary="------------ED9FEC04165E4D4BEF87F6FC" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac , 26500@debbugs.gnu.org This is a multi-part message in MIME format. --------------ED9FEC04165E4D4BEF87F6FC Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Am 16.04.2017 um 10:53 schrieb Arun Isaac: > Instead of mentioning p7zip, unrar and mupdf in the description, it > would be better if we could make them inputs and patch all references to > the executables in the source with their absolute paths. Could you try this? I could try that, but mupdf is a pretty heavy dependency. guix size says it's self-size is 208MiB and total-size is 491MiB. I personally never needed it with mcomix, so I like that it is optional. Is there some way to define a package with optional inputs? For now I'm appending my WIP that should address your previous remarks. --------------ED9FEC04165E4D4BEF87F6FC Content-Type: text/x-patch; name="0001-gnu-Add-mcomix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-mcomix.patch" =46rom 493a6e0c1c5dd9ef6b454b31be9b80646f201fb4 Mon Sep 17 00:00:00 2001 From: nee Date: Fri, 14 Apr 2017 19:09:40 +0200 Subject: [PATCH] gnu: Add mcomix. * gnu/packages/image-viewers.scm (mcomix): New variable. --- gnu/packages/image-viewers.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm index 830ce10ea..bfcad99f1 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -6,6 +6,7 @@ ;;; Copyright =C2=A9 2017 Alex Griffin ;;; Copyright =C2=A9 2017 ng0 ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2017 nee ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,6 +29,7 @@ #:use-module (guix packages) #:use-module (guix build-system gnu) #:use-module (guix build-system cmake) + #:use-module (guix build-system python) #:use-module (gnu packages autotools) #:use-module (gnu packages algebra) #:use-module (gnu packages base) @@ -46,6 +48,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages qt) #:use-module (gnu packages xorg) + #:use-module (gnu packages python) #:use-module (gnu packages)) =20 (define-public feh @@ -360,3 +363,30 @@ imaging. It supports several HDR and LDR image form= ats, and it can: @item Copy EXIF data between sets of images. @end itemize\n") (license license:gpl2+))) + +(define-public mcomix + (package + (name "mcomix") + (version "1.2.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version= + "/mcomix-" version ".tar.bz2")) + (sha256 + (base32 + "0fzsf9pklhfs1rzwzj64c0v30b74nk94p93h371rpg45qnfiahvy")))) + (build-system python-build-system) + ;; Python 2.5 or newer (Python 3 and up is not supported) + (arguments `(#:python ,python-2)) + (inputs `(("python2-pygtk" ,python2-pygtk) + ("python2-pillow" ,python2-pillow))) + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") + (synopsis "Image viewer for comics") + (description "MComix is a customizable image viewer that specializes= as +a comic and manga reader. It supports a variety of container formats +including CBR, CBZ, CB7, CBT, LHA. +For 7z support install the p7zip package. +For rar support install the unrar package. +For pdf support install the mupdf package.") + (license license:gpl2+))) --=20 2.12.2 --------------ED9FEC04165E4D4BEF87F6FC--