From: Arun Isaac <arunisaac@systemreboot.net>
To: 26500@debbugs.gnu.org
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Sat, 15 Apr 2017 14:06:22 +0530 [thread overview]
Message-ID: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> (raw)
In-Reply-To: <db842df1-7c87-58a0-2eab-b91e3a36851b@cock.li>
> Hello, here is mcomix.
Thanks for the patch!
> I tested it with zip, CBZ, 7zip pdf files, and a directory with normal
> images, they all work fine.
>
> I also tried unrar, but couldn't extract any archive with it, neither
> through mcomix, nor manually through the commandline tool, so this might
> be a separate problem.
I'm yet to actually test running the application. Will do so and get
back in a while. Meanwhile, other changes.
> + ;; Python 2.5 or newer (Python 3 and up is not supported)
> + (arguments `(#:python ,python-2))
You can remove the comment. It's more or less obvious from the
'arguments' section that mcomix needs python 2.
> + (propagated-inputs `(("python2-pygtk" ,python2-pygtk)
> + ("gtk+" ,gtk+)
> + ("python2-pillow" ,python2-pillow)))
These are inputs not propagated-inputs. propagated-inputs are only
required for python libraries. For python applications such as mcomix,
the executable gets wrapped in a script which sets the correct
PYTHONPATH variable. Look at $out/bin/mcomix and $out/bin/.mcomix-real
Also, is the gtk+ dependency required? mcomix seems to build and run
fine on my system without it.
> + (description "A customizable image viewer that specializes as
> +a comic and manga reader. It supports a variety of container formats
> +including CBR, CBZ, CB7, CBT, LHA.
Please make this "MComix is a ... ". See
https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
> + (license license:gpl2)))
This should be license:gpl2+. When no license version is explicitly
specified in the source headers, it is of the "or later" variant. See
https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00026.html
Also, add a copyright header for yourself at the top of the source file
(gnu/packages/image-viewers.scm in this case).
next prev parent reply other threads:[~2017-04-15 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 17:50 bug#26500: [PATCH] gnu: Add mcomix nee
2017-04-15 8:36 ` Arun Isaac [this message]
2017-04-15 9:09 ` ng0
2017-04-16 8:53 ` Arun Isaac
2017-04-17 4:45 ` nee
2017-04-17 19:21 ` Arun Isaac
2017-04-18 22:09 ` nee
2017-04-19 15:53 ` Arun Isaac
2017-04-19 19:54 ` ng0
2017-04-21 9:00 ` Ludovic Courtès
2017-04-21 17:57 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=26500@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.