all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: 26500@debbugs.gnu.org
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Sun, 16 Apr 2017 14:23:02 +0530	[thread overview]
Message-ID: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> (raw)
In-Reply-To: <20170415090932.ed7dzowf6s5cwln5@abyayala>


> No, I think a short comment behind or above the #:python keyword is
> necessary, in case someone in the future wonders "Hey, why do we package
> this for python 2 only and not for python 3" even if both languages are
> developed in parallel.

Ok, it doesn't hurt to keep the comment. Let's keep it.

> +    (description "A customizable image viewer that specializes as
> +a comic and manga reader.  It supports a variety of container formats
> +including CBR, CBZ, CB7, CBT, LHA.
> +For 7z support install the p7zip package.
> +For rar support install the unrar package.
> +For pdf support install the mupdf package.")

Instead of mentioning p7zip, unrar and mupdf in the description, it
would be better if we could make them inputs and patch all references to
the executables in the source with their absolute paths. Could you try this?

  reply	other threads:[~2017-04-16  8:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 17:50 bug#26500: [PATCH] gnu: Add mcomix nee
2017-04-15  8:36 ` Arun Isaac
2017-04-15  9:09   ` ng0
2017-04-16  8:53     ` Arun Isaac [this message]
2017-04-17  4:45       ` nee
2017-04-17 19:21         ` Arun Isaac
2017-04-18 22:09           ` nee
2017-04-19 15:53             ` Arun Isaac
2017-04-19 19:54               ` ng0
2017-04-21  9:00               ` Ludovic Courtès
2017-04-21 17:57                 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26500@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.