From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e50RJ-0007Pr-W5 for guix-patches@gnu.org; Wed, 18 Oct 2017 22:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e50RG-0008K7-O2 for guix-patches@gnu.org; Wed, 18 Oct 2017 22:20:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e50RG-0008K2-KA for guix-patches@gnu.org; Wed, 18 Oct 2017 22:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e50RG-0005Z2-AO for guix-patches@gnu.org; Wed, 18 Oct 2017 22:20:02 -0400 Subject: [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support. Resent-Message-ID: Date: Wed, 18 Oct 2017 22:19:06 -0400 From: Andy Patterson Message-ID: <20171018221906.7f76610a@uwaterloo.ca> In-Reply-To: <87mv4rkywx.fsf@member.fsf.org> References: <20171015151545.024a589f@uwaterloo.ca> <20171015200328.4830-1-ajpatter@uwaterloo.ca> <87mv4rkywx.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 28853@debbugs.gnu.org Hi, On Mon, 16 Oct 2017 21:25:18 +0800 iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > Andy Patterson writes: >=20 > > virt-manager: Enable gtk schemas and glib modules support. =20 >=20 > How about: Wrap with GSettings schema and GIO modules search paths. >=20 > Otherwise, this patch series look good to me, thanks! Sounds good, updated patch appened: -- Andy =46rom f504ccc9e961e7657261a478e278c142b9006e6b Mon Sep 17 00:00:00 2001 From: Andy Patterson Date: Sun, 15 Oct 2017 11:47:16 -0400 Subject: [PATCH] gnu: virt-manager: Wrap with GSettings schema and GIO modu= les search paths. Fixes a crash when opening the file chooser dialog. * gnu/packages/virtualization.scm (virt-manager)[arguments] <#:imported-modules>: Add (guix build glib-or-gtk-build-system). <#:modules>: Import (guix build glib-or-gtk-build-system) as glib-or-gtk:. <#:arguments>: Add 'glib-or-gtk-compile-schemas and 'glib-or-gtk-wrap. --- gnu/packages/virtualization.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.= scm index 4e384e79a..5cdf6d09b 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -499,9 +499,12 @@ virtualization library.") ;; Some of the tests seem to require network access to install virt= ual ;; machines. #:tests? #f + #:imported-modules ((guix build glib-or-gtk-build-system) + ,@%python-build-system-modules) #:modules ((ice-9 match) (srfi srfi-26) (guix build python-build-system) + ((guix build glib-or-gtk-build-system) #:prefix glib-or-= gtk:) (guix build utils)) #:phases (modify-phases %standard-phases @@ -528,7 +531,11 @@ virtualization library.") `("GI_TYPELIB_PATH" ":" prefix ,(filter identity paths)))) bin-files)) - #t))))) + #t)) + (add-after 'install 'glib-or-gtk-compile-schemas + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-sc= hemas)) + (add-after 'install 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) (inputs `(("gtk+" ,gtk+) ("gtk-vnc" ,gtk-vnc) --=20 2.14.2