From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e50MS-0006RY-Jw
	for guix-patches@gnu.org; Wed, 18 Oct 2017 22:15:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e50MQ-00028Z-FB
	for guix-patches@gnu.org; Wed, 18 Oct 2017 22:15:04 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40255)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e50MQ-000288-A9
	for guix-patches@gnu.org; Wed, 18 Oct 2017 22:15:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e50MP-0005R8-UO
	for guix-patches@gnu.org; Wed, 18 Oct 2017 22:15:01 -0400
Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection
	support.
Resent-Message-ID: <handler.28853.B28853.150837929520869@debbugs.gnu.org>
Date: Wed, 18 Oct 2017 22:14:42 -0400
From: Andy Patterson <ajpatter@uwaterloo.ca>
Message-ID: <20171018221442.6e140c5b@uwaterloo.ca>
In-Reply-To: <87r2u3kzd0.fsf@member.fsf.org>
References: <20171015151545.024a589f@uwaterloo.ca>
	<20171015200328.4830-2-ajpatter@uwaterloo.ca>
	<87r2u3kzd0.fsf@member.fsf.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Cc: 28853@debbugs.gnu.org

Hey =E5=AE=8B=E6=96=87=E6=AD=A6,

Thanks for the review!

On Mon, 16 Oct 2017 21:15:39 +0800
iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote:

> Andy Patterson <ajpatter@uwaterloo.ca> writes:
>=20
> > * gnu/packages/virtualization.scm
> > (qemu)[arguments]<#:configure-flags>: New argument.
> > [inputs]: Add usbredir.
> > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even
> > when they are set by qemu.
> > [inputs]: Remove usbredir. =20
>=20
> Doesn't the 'configure' script auto-detect usb redirection support
> when usbredir is available?

To me, the advantage of specifying the enabled features is that the
build will require the dependencies to be available for that feature
even if they change. So, if more dependencies are required for the
feature in future versions, the build will immediately inform us, rather
than somewhat silently dropping support. Thoughts?

[...]

Thanks,

--
Andy