unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#51779] [PATCH] Add phonesim 1.21
@ 2021-11-11 22:14 Demis Balbach
  2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Demis Balbach @ 2021-11-11 22:14 UTC (permalink / raw)
  To: 51779; +Cc: Demis Balbach

---
 gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..77914fb4d7 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright © 2021 Demis Balbach <db@minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -94,6 +95,35 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))
 
+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=gcc")))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phone Simulator for modem testing")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
-- 
2.33.0





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51779] [PATCH] Add phonesim 1.21
  2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
@ 2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
  2021-11-12 19:19 ` db
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2021-11-12 15:05 UTC (permalink / raw)
  To: Demis Balbach; +Cc: 51779

Demis,

Thanks for the patch!  Here are a few low-hanging thoughts (not a full 
review):

Check the git log for commits adding new packages for the expected 
'change-log-style' commit message.

On 2021-11-11 23:14, Demis Balbach wrote:
> +     `(#:configure-flags
> +       (list "--enable-maintainer-mode"

This is unusual enough to require a comment explaining why it's here.

> +             "CC=gcc")))

This breaks cross-compilation: the cross GCC is called something like 
'x86_64-blah-bloo-gcc', not 'gcc'.  There's a helper in (guix utils) 
IIRC that returns the right cc for the target:

   (string-append "CC=" ,(cc-for-target))

> +    (description "Phone Simulator for modem testing")

This should be at least several lines of complete sentences ("Phonesim 
simulates blah...").

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51779] [PATCH] Add phonesim 1.21
  2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
  2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
@ 2021-11-12 19:19 ` db
  2021-11-13 10:01   ` Josselin Poiret via Guix-patches via
  2021-11-23 18:37 ` Demis Balbach
  2021-11-23 18:55 ` Demis Balbach
  3 siblings, 1 reply; 7+ messages in thread
From: db @ 2021-11-12 19:19 UTC (permalink / raw)
  To: 51779

Hello Tobias,

thank you for your input. This is my first attempt at submitting a patch
through a mailing list. I expected some mistakes. On top of that, my
guile is bad as well (I'm just starting with it).

> Check the git log for commits adding new packages for the expected
> 'change-log-style' commit message.

Thanks. I think it should have been `[PATCH] gnu: Add phonesim'. How can
I change that?

> This is unusual enough to require a comment explaining why it's here.

The short answer is - I don't know. I copied it from the source:

https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tree/bootstrap-con
figure

I should also mention that I do not have any experience with the
application. I never used it nor do I really understand what it does. I
just submitted a patch because it is part of what needs to be done in
order to get bluetooth headsets fully working in Guix (with microphone),
see

https://wiki.archlinux.org/title/Bluetooth_headset#HFP_not_working_with_Puls
eAudio

This is beside the point, but I'm mentioning it to give a little
background why I may not be able to give insight on why things are done
a certain way.

That being said, here is the new patch version:

---
 gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..6e3c69ce91 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright C 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright C 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright C 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright C 2021 Demis Balbach <db@minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -87,6 +88,7 @@ (define-module (gnu packages telephony)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages flex)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -94,6 +96,37 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))

+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url
"https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=" ,(cc-for-target))))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phonesim is a modem emulator that oFono uses for
development
+and testing. This allows oFono to be used by any host without requiring
special
+GSM (or other) hardware.")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
--
2.33.0

Greetings,

Demis.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51779] [PATCH] Add phonesim 1.21
  2021-11-12 19:19 ` db
@ 2021-11-13 10:01   ` Josselin Poiret via Guix-patches via
  0 siblings, 0 replies; 7+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2021-11-13 10:01 UTC (permalink / raw)
  To: db, 51779; +Cc: dev

Hello Demis,

About the ChangeLog style, it is documented at [1], and it mostly
concerns the contents of the commit message.  In the case of this patch,
I think it should be

--8<---------------cut here---------------start------------->8---
gnu: Add phonesim.

* gnu/packages/telephony.scm (phonesim): Add new variable.
--8<---------------cut here---------------end--------------->8---

You can take a look at the complete commit messages in the git log to
get a feel for what needs to be included in them.

As for the patch, it looks good to me, but I'm no expert yet.  Glad to
see your first contribution though!

[1] https://www.gnu.org/prep/standards/html_node/Change-Logs.html

Best,
Josselin Poiret




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51779] [PATCH] Add phonesim 1.21
  2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
  2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
  2021-11-12 19:19 ` db
@ 2021-11-23 18:37 ` Demis Balbach
  2021-11-23 18:55 ` Demis Balbach
  3 siblings, 0 replies; 7+ messages in thread
From: Demis Balbach @ 2021-11-23 18:37 UTC (permalink / raw)
  To: 51779


> You can take a look at the complete commit messages in the git log to
> get a feel for what needs to be included in them.

Thank you Josselin.

I'm still quite unfamiliar with patches through mailing lists: Do I have
to change anything in this patch for it to get merged, or should I just
keep the naming convention in mind for future patches?

Greetings,

Demis.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51779] [PATCH] Add phonesim 1.21
  2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
                   ` (2 preceding siblings ...)
  2021-11-23 18:37 ` Demis Balbach
@ 2021-11-23 18:55 ` Demis Balbach
  2021-12-05 20:57   ` bug#51779: " Nicolas Goaziou
  3 siblings, 1 reply; 7+ messages in thread
From: Demis Balbach @ 2021-11-23 18:55 UTC (permalink / raw)
  To: 51779

This is the new patch after changing the commit message.

* gnu/packages/telephony.scm (phonesim): Add new variable.
---
 gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..6e3c69ce91 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright © 2021 Demis Balbach <db@minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -87,6 +88,7 @@ (define-module (gnu packages telephony)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages flex)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -94,6 +96,37 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))

+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=" ,(cc-for-target))))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phonesim is a modem emulator that oFono uses for development
+and testing. This allows oFono to be used by any host without requiring special
+GSM (or other) hardware.")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
--
2.34.0

Cheers,

Demis.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#51779: [PATCH] Add phonesim 1.21
  2021-11-23 18:55 ` Demis Balbach
@ 2021-12-05 20:57   ` Nicolas Goaziou
  0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Goaziou @ 2021-12-05 20:57 UTC (permalink / raw)
  To: Demis Balbach; +Cc: 51779-done

Hello,

Demis Balbach <db@minikn.xyz> writes:

> * gnu/packages/telephony.scm (phonesim): Add new variable.

I fixed the commit message and applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-12-05 20:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
2021-11-12 19:19 ` db
2021-11-13 10:01   ` Josselin Poiret via Guix-patches via
2021-11-23 18:37 ` Demis Balbach
2021-11-23 18:55 ` Demis Balbach
2021-12-05 20:57   ` bug#51779: " Nicolas Goaziou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).