unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Demis Balbach <db@minikn.xyz>
Cc: 51779@debbugs.gnu.org
Subject: [bug#51779] [PATCH] Add phonesim 1.21
Date: Fri, 12 Nov 2021 16:05:35 +0100	[thread overview]
Message-ID: <edb6cf8cfa247f21082c2ed48e62aea1@tobias.gr> (raw)
In-Reply-To: <20211111221457.6025-1-db@minikn.xyz>

Demis,

Thanks for the patch!  Here are a few low-hanging thoughts (not a full 
review):

Check the git log for commits adding new packages for the expected 
'change-log-style' commit message.

On 2021-11-11 23:14, Demis Balbach wrote:
> +     `(#:configure-flags
> +       (list "--enable-maintainer-mode"

This is unusual enough to require a comment explaining why it's here.

> +             "CC=gcc")))

This breaks cross-compilation: the cross GCC is called something like 
'x86_64-blah-bloo-gcc', not 'gcc'.  There's a helper in (guix utils) 
IIRC that returns the right cc for the target:

   (string-append "CC=" ,(cc-for-target))

> +    (description "Phone Simulator for modem testing")

This should be at least several lines of complete sentences ("Phonesim 
simulates blah...").

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.




  reply	other threads:[~2021-11-12 15:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-11-12 19:19 ` db
2021-11-13 10:01   ` Josselin Poiret via Guix-patches via
2021-11-23 18:37 ` Demis Balbach
2021-11-23 18:55 ` Demis Balbach
2021-12-05 20:57   ` bug#51779: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edb6cf8cfa247f21082c2ed48e62aea1@tobias.gr \
    --to=guix-patches@gnu.org \
    --cc=51779@debbugs.gnu.org \
    --cc=db@minikn.xyz \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).