From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNbQIy2Nj2GvyAAAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 11:02:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GM+FHy2Nj2GkVwAA1q6Kng (envelope-from ) for ; Sat, 13 Nov 2021 10:02:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BD4C1F68B for ; Sat, 13 Nov 2021 11:02:21 +0100 (CET) Received: from localhost ([::1]:52988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlprX-0004mK-Bn for larch@yhetil.org; Sat, 13 Nov 2021 05:02:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlprG-0004jZ-C7 for guix-patches@gnu.org; Sat, 13 Nov 2021 05:02:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlprG-0002n2-1Z for guix-patches@gnu.org; Sat, 13 Nov 2021 05:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlprF-00017d-Vf for guix-patches@gnu.org; Sat, 13 Nov 2021 05:02:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51779] [PATCH] Add phonesim 1.21 Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Nov 2021 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51779 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: db@minikn.xyz, 51779@debbugs.gnu.org Cc: dev@jpoiret.xyz Received: via spool by 51779-submit@debbugs.gnu.org id=B51779.16367976944272 (code B ref 51779); Sat, 13 Nov 2021 10:02:01 +0000 Received: (at 51779) by debbugs.gnu.org; 13 Nov 2021 10:01:34 +0000 Received: from localhost ([127.0.0.1]:46560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlpqo-00016q-C2 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 05:01:34 -0500 Received: from jpoiret.xyz ([206.189.101.64]:42152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlpqk-00016g-Ff for 51779@debbugs.gnu.org; Sat, 13 Nov 2021 05:01:33 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id E51AA184D67; Sat, 13 Nov 2021 10:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1636797688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ocBxfoiyI/Afd4aUQDNK3nrzD5JjQ+oCY+au/fBu6CQ=; b=HpBQTRT5F3Tbye2mdEFlRKoRmdaL8yF46jGhpZL5PksBatmKRtDHS8jRJKtQmM3I6IiQeu jj2aCoPSLi9EFp3Jq2VXf+dluHmprxejqKrn/TkBUzFdCuHxHKPb00ZUlyR7Vtx6P0tP/E 6HysqWq141KmmcISRsOg/0P26fDyjHVkoWR4jxkwwdtedQj5tpJNYZJVngJBFCB48m1doa 1OlWsGr94BnFAGWQK+pyp0NSLxHHk4Ys5B5TOnYQ8j2Jv9iyuZx2SXicTlyLiPbuyGrELc J0y/fFC31ij70PYqMqkJCKMZ9I9xfBNqGh4e2/Kqv9YzEDGCZtRl6Fjy3FTAuA== In-Reply-To: <006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz> References: <20211111221457.6025-1-db@minikn.xyz> <006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz> Date: Sat, 13 Nov 2021 10:01:26 +0000 Message-ID: <87r1bk9xxl.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636797741; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ocBxfoiyI/Afd4aUQDNK3nrzD5JjQ+oCY+au/fBu6CQ=; b=YOAcNFQELMOhPkAB30OcNqp4IXXJe4aueujz9StzGIM4QbAXcaYWZcKEmmR8gDetuVeLw5 0UVLE8ggzCjrE7vxki4+b53dLAcaFd+1oHL8FBtGh/zRa2Fy5VI89KbJAsScnQbDz/+3qY HutMTZb2zknIACRShMHz9ZchF91Q+85+jeQmhfkhtW8v2nfk112ecnQM4+DuDRVuPVnQUe pNcJVpyDYbSHEHIYC9UnOZrMlVRfquo76UOCmhqJcj3i0AbpaJd9SdwKX2uq3FfIbc8bJi 9ANj8lt0oWgcYtq756BY6MN6Hx4oZtyTs3MKfvtzsHJtJwDpwN8tCC/m4aeuuA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636797741; a=rsa-sha256; cv=none; b=sQnTmuPOT2M6G4R7qYhv6mQmq5rUVEHrDWQvlhEMaA8WWtrAR6DDCyM6NVZctghKmyNk4B z7/7tdRCiqraXH7xnXf7KGmZWi1w/n28APjQH3j35nv8MyaJkYedojqz61eVJDuClj+Cc0 FBD76NaiOy0TKA7oM1/7JJkYynZhU6nhD6Ac/l0s9TROuRK87m+Ns8UXFF+B4QcwI2SuUi alzN0yAfwCboR1aSSjOzUfqSL61TUkWr+XIsdgujG8bYbEA7KoxVptW70haaavRSKAVEgv GcTu2Zg27C6SbwLPxwoUtWq91mSwPZJo6LGLZumiSFFWKVXvu/8sbvoITAyMzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=HpBQTRT5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=HpBQTRT5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3BD4C1F68B X-Spam-Score: -1.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: IRSA1dIZeTvh Hello Demis, About the ChangeLog style, it is documented at [1], and it mostly concerns the contents of the commit message. In the case of this patch, I think it should be --8<---------------cut here---------------start------------->8--- gnu: Add phonesim. * gnu/packages/telephony.scm (phonesim): Add new variable. --8<---------------cut here---------------end--------------->8--- You can take a look at the complete commit messages in the git log to get a feel for what needs to be included in them. As for the patch, it looks good to me, but I'm no expert yet. Glad to see your first contribution though! [1] https://www.gnu.org/prep/standards/html_node/Change-Logs.html Best, Josselin Poiret