From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: db@minikn.xyz, 51779@debbugs.gnu.org
Cc: dev@jpoiret.xyz
Subject: [bug#51779] [PATCH] Add phonesim 1.21
Date: Sat, 13 Nov 2021 10:01:26 +0000 [thread overview]
Message-ID: <87r1bk9xxl.fsf@jpoiret.xyz> (raw)
In-Reply-To: <006401d7d7fa$27f236e0$77d6a4a0$@minikn.xyz>
Hello Demis,
About the ChangeLog style, it is documented at [1], and it mostly
concerns the contents of the commit message. In the case of this patch,
I think it should be
--8<---------------cut here---------------start------------->8---
gnu: Add phonesim.
* gnu/packages/telephony.scm (phonesim): Add new variable.
--8<---------------cut here---------------end--------------->8---
You can take a look at the complete commit messages in the git log to
get a feel for what needs to be included in them.
As for the patch, it looks good to me, but I'm no expert yet. Glad to
see your first contribution though!
[1] https://www.gnu.org/prep/standards/html_node/Change-Logs.html
Best,
Josselin Poiret
next prev parent reply other threads:[~2021-11-13 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 22:14 [bug#51779] [PATCH] Add phonesim 1.21 Demis Balbach
2021-11-12 15:05 ` Tobias Geerinckx-Rice via Guix-patches via
2021-11-12 19:19 ` db
2021-11-13 10:01 ` Josselin Poiret via Guix-patches via [this message]
2021-11-23 18:37 ` Demis Balbach
2021-11-23 18:55 ` Demis Balbach
2021-12-05 20:57 ` bug#51779: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1bk9xxl.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=51779@debbugs.gnu.org \
--cc=db@minikn.xyz \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).