From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SPIJL/GDjmEGUgAAgWs5BA (envelope-from ) for ; Fri, 12 Nov 2021 16:10:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QKGPKvGDjmGubAAAbx9fmQ (envelope-from ) for ; Fri, 12 Nov 2021 15:10:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47297312F1 for ; Fri, 12 Nov 2021 16:10:41 +0100 (CET) Received: from localhost ([::1]:37322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlYCO-0004px-Cr for larch@yhetil.org; Fri, 12 Nov 2021 10:10:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlY7u-0000Uk-V9 for guix-patches@gnu.org; Fri, 12 Nov 2021 10:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlY7u-0006cs-LF for guix-patches@gnu.org; Fri, 12 Nov 2021 10:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlY7t-00054l-SM for guix-patches@gnu.org; Fri, 12 Nov 2021 10:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51779] [PATCH] Add phonesim 1.21 Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51779 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Demis Balbach Cc: 51779@debbugs.gnu.org Received: via spool by 51779-submit@debbugs.gnu.org id=B51779.163672954219487 (code B ref 51779); Fri, 12 Nov 2021 15:06:01 +0000 Received: (at 51779) by debbugs.gnu.org; 12 Nov 2021 15:05:42 +0000 Received: from localhost ([127.0.0.1]:45719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlY7Z-00054F-WB for submit@debbugs.gnu.org; Fri, 12 Nov 2021 10:05:42 -0500 Received: from tobias.gr ([80.241.217.52]:42796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlY7X-000544-65 for 51779@debbugs.gnu.org; Fri, 12 Nov 2021 10:05:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=UneAg4vG2oV6Y +u3at+kU1CwL3sbLL4/2EGRSG0QBcs=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=hqskmcYY4skuRsZdpQu7IOJcSc5p8XFq73ERON+g5 BVXPTg/6/vBJMiPGKYtX4PieSNcPyeO8kjr3e9whzyEg2sMio6xqn6ZcT0UQxiYNbIBbEG WmlOfyU3c4SnF0qL9/uifGnmCYhbaq23oIGK4bv3jz+7n7uRvnb6ErY39+AGWNg+3MVNBE bceiH7vcU4Tm8gNWANNNof45ueVaEprFBJfXrCVzjgBGp2lm5dQYtaB7CBfQMH8pt3zN/7 gBH9hMnvpouj9sTfGPsInzjOO8K7qxFVqRVI2i+cjLp0k6N8JDF4TakonWgcK4Ap3G8CUK 7tDpqkDKiXcxY33fYM9Ww== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 74abcd8d; Fri, 12 Nov 2021 15:05:36 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 12 Nov 2021 16:05:35 +0100 In-Reply-To: <20211111221457.6025-1-db@minikn.xyz> References: <20211111221457.6025-1-db@minikn.xyz> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636729841; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UneAg4vG2oV6Y+u3at+kU1CwL3sbLL4/2EGRSG0QBcs=; b=e5UqZ1nv0YDCTfABtU6AFFqmptmHa3HlzpV9/WxSx1of8DmshQ+w8K3Sr+mqIKMGMlqT0J ADILIuvPfcnONejwfcaCn2cC9OlnjH2dvPkKTjyMjfb+7/7hdu/ipIRZ9tkQdEHWCcRfsc kUcMiCyl8rbKdf+2LrxtBUGNW1R/T2bs9xft4ggTPQWXjCW4vpaY0cO7gnjxsFGFKMU4Iv rvma6HBhpQjCIY0YjRMlwK6sapZbrVovYBXM2RIR2i7Qbvs5qvbjXLkN6alAas29j0lVa4 DICdYR8xrncRwFgWXrlJYb1m1RoyvUWp8gI4cU78M/1255Ci8WaXU0hFRWUvTA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636729841; a=rsa-sha256; cv=none; b=puY/aEzd+oERgtCU39rU3yRU1IhoQTPuYa9oFqWadqXDNi9qmXS/IISJX93JGUex2MTfXQ fEIBS0lHrqV4UoIkaU/BOZ7xCeqmxfDKHMvOqP0msf2exCGFLMqUxFiPShSizj+rju0T7N n1RlFPR4Qdpr+1tW5P+UPyM4rQH7sc6P6txsshg4HPIPduuTHPGHlejUHNwWToEojLzTYO sPw8TVm1cugfIgxzJmj54OGFPH7hFtbzbnvlU0Ax4xj8QnP0Wg3BM86I768d0w1Xwd45qh PDQ/gV8JYSoFTUC5N/VTjp8z3i7sNnAqKPt9Vgz/FDDSVGClDlWeY3RdYFQAcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=hqskmcYY; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=hqskmcYY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 47297312F1 X-Spam-Score: -3.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: lJRWRschzJqA Demis, Thanks for the patch! Here are a few low-hanging thoughts (not a full review): Check the git log for commits adding new packages for the expected 'change-log-style' commit message. On 2021-11-11 23:14, Demis Balbach wrote: > + `(#:configure-flags > + (list "--enable-maintainer-mode" This is unusual enough to require a comment explaining why it's here. > + "CC=gcc"))) This breaks cross-compilation: the cross GCC is called something like 'x86_64-blah-bloo-gcc', not 'gcc'. There's a helper in (guix utils) IIRC that returns the right cc for the target: (string-append "CC=" ,(cc-for-target)) > + (description "Phone Simulator for modem testing") This should be at least several lines of complete sentences ("Phonesim simulates blah..."). Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity.