unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38553] [PATCH 00/12] Add two KDE packages and 10 KDE utils
@ 2019-12-09 21:52 Hartmut Goebel
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
  0 siblings, 1 reply; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:52 UTC (permalink / raw)
  To: 38553

These ones have not too much dependencies on other KDE packages.

Hartmut Goebel (12):
  gnu: Add grantleetheme.
  gnu: Add zeroconf-ioslave.
  gnu: Add kate.
  gnu: Add kmag.
  gnu: Add kmousetool.
  gnu: Add kmouth.
  gnu: Add kronometer.
  gnu: Add krusader.
  gnu: Add okteta.
  gnu: Add rsibreak.
  gnu: Add smb4k.
  gnu: Add sweeper.

 gnu/local.mk               |   1 +
 gnu/packages/kde-utils.scm | 530 +++++++++++++++++++++++++++++++++++++
 gnu/packages/kde.scm       |  63 +++++
 3 files changed, 594 insertions(+)
 create mode 100644 gnu/packages/kde-utils.scm

-- 
2.21.0

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-09 21:52 [bug#38553] [PATCH 00/12] Add two KDE packages and 10 KDE utils Hartmut Goebel
@ 2019-12-09 21:53 ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
                     ` (11 more replies)
  0 siblings, 12 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde.scm (grantleetheme): New variable.
---
 gnu/packages/kde.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index b4cbd5a721..33bcaaefd2 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -60,8 +60,43 @@
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg))
 
+(define-public grantleetheme
+  (package
+    (name "grantleetheme")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/grantleetheme-" version ".tar.xz"))
+       (sha256
+        (base32 "0j77q1yyfmggzgkqgcw2xr0v9xg3h5cdhh8jry8h2llw75ahy6xb"))))
+    (properties `((tags . ("Desktop" "KDE" "Themes"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("libxml2" ,libxml2))) ;; xmllint required for tests
+    (inputs
+     `(("grantlee" ,grantlee)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("knewstuff" ,knewstuff)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases (@ (guix build qt-build-system) %standard-phases)
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://cgit.kde.org/grantleetheme.git")
+    (synopsis "Library providing grantlee theme support")
+    (description "This library provides grantlee theme support.")
+    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
+
 (define-public kdenlive
   (let ((version "18.08.1"))
     (package
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 03/12] gnu: Add kate Hartmut Goebel
                     ` (10 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde.scm (zeroconf-ioslave): New variable.
---
 gnu/packages/kde.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 33bcaaefd2..d1715fed68 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -691,3 +691,31 @@ system-wide profiler for Linux using statistical sampling with hardware
 performance counters.  There also exist converters for profiling output of
 Python, PHP, and Perl.")
     (license license:gpl2)))
+
+(define-public zeroconf-ioslave
+  (package
+    (name "zeroconf-ioslave")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/zeroconf-ioslave-" version ".tar.xz"))
+       (sha256
+        (base32 "1vbi4kpyrk530q2dj8ql2i0gxjybdbmkqpl8vkhrihl7r7f0xc5p"))))
+    (properties `((tags . ("Desktop" "KDE" "Network"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kdbusaddons" ,kdbusaddons)
+       ("kdnssd" ,kdnssd)
+       ("ki18n" ,ki18n)
+       ("kio" ,kio)
+       ("qtbase" ,qtbase)))
+    (home-page "https://kde.org/applications/internet/org.kde.zeroconf_ioslave")
+    (synopsis "DNS-SD Service Discovery Monitor")
+    (description "Adds an entry to Dolphin's Network page to show local
+services such as printers which advertise themselves with DNSSD (called Avahi
+or Bonjour by other projects).")
+    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 03/12] gnu: Add kate.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 04/12] gnu: Add kmag Hartmut Goebel
                     ` (9 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm: New file.
* gnu/local.mk (MODULES): Add it.
---
 gnu/local.mk               |  1 +
 gnu/packages/kde-utils.scm | 93 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 94 insertions(+)
 create mode 100644 gnu/packages/kde-utils.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index b2938e878b..f5cd1cd7a9 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -280,6 +280,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/kde.scm				\
   %D%/packages/kde-frameworks.scm		\
   %D%/packages/kde-plasma.scm			\
+  %D/packages/kde-utils.scm			\
   %D%/packages/kerberos.scm			\
   %D%/packages/key-mon.scm			\
   %D%/packages/kodi.scm				\
diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
new file mode 100644
index 0000000000..1a9f7cf56a
--- /dev/null
+++ b/gnu/packages/kde-utils.scm
@@ -0,0 +1,93 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2017, 2019 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages kde-utils)
+  #:use-module (guix build-system qt)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages kde-frameworks)
+  #:use-module (gnu packages kde-plasma)
+  #:use-module (gnu packages qt))
+
+(define-public kate
+  (package
+    (name "kate")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/kate-" version ".tar.xz"))
+       (sha256
+        (base32 "0wgcw10c4grkmsyp79ashwgpy59lgrinwdib4mjclpw2grp0g7xb"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kactivities" ,kactivities)
+       ("kconfig" ,kconfig)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemmodels" ,kitemmodels)
+       ("threadweaver" ,threadweaver)
+       ("knewstuff" ,knewstuff)
+       ("kio" ,kio)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kparts" ,kparts)
+       ("ktexteditor" ,ktexteditor)
+       ("kwallet" ,kwallet)
+       ("plasma-framework" ,plasma-framework)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)
+       ("qtscript" ,qtscript)))
+    (arguments
+     `(#:tests? #f ;; 2/7 tests fail
+       #:phases
+       (modify-phases (@ (guix build qt-build-system) %standard-phases)
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             (setenv "XDG_CACHE_HOME" "/tmp/xdg-cache")
+             #t)))))
+    (home-page "https://kate-editor.org/")
+    (synopsis "Multi-document, multi-view text editor")
+    (description "Kate is a powerful text editor that can open multiple files
+simultaneously.
+
+With a built-in terminal, syntax highlighting, and tabbed sidebar, it performs
+as a lightweight but capable development environment.  Kate's many tools,
+plugins, and scripts make it highly customizable.
+
+Kate's features include:
+@itemize
+@item Multiple saved sessions, each with numerous files
+@item Scriptable syntax highlighting, indentation, and code-folding
+@item Configurable templates and text snippets
+@item Symbol viewers for C, C++, and Python
+@item XML completion and validation
+@end itemize")
+    (license (list license:gpl2+ license:lgpl2.0))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 04/12] gnu: Add kmag.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 03/12] gnu: Add kate Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 05/12] gnu: Add kmousetool Hartmut Goebel
                     ` (8 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (kmag): New variable.
---
 gnu/packages/kde-utils.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 1a9f7cf56a..722a9aaaf3 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -91,3 +91,34 @@ Kate's features include:
 @item XML completion and validation
 @end itemize")
     (license (list license:gpl2+ license:lgpl2.0))))
+
+(define-public kmag
+  (package
+    (name "kmag")
+    (version "19.08.3")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://kde/stable/applications/" version
+                          "/src/kmag-" version ".tar.xz"))
+      (sha256
+       (base32 "0l69mgnh2mmkxawwibqdx9n7myl6qqnr2fd3mpsg2bzpcfvmsvi1"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("ki18n" ,ki18n)
+       ("kio" ,kio)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ;; TODO: QAccessibilityClient - libqaccessibilityclien
+       ("qtbase" ,qtbase)))
+    (home-page "https://kde.org/applications/utilities/org.kde.kmag")
+    (synopsis "Screen magnifier tool")
+    (description "You can use KMagnifier to magnify a part of the screen just
+as you would use a lens to magnify a newspaper fine-print or a photograph.
+This application is useful for a variety of people: from researchers to
+artists to web-designers to people with low vision.")
+    (license (list license:gpl2+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 05/12] gnu: Add kmousetool.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (2 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 04/12] gnu: Add kmag Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 06/12] gnu: Add kmouth Hartmut Goebel
                     ` (7 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (kmousetool): New variable.
---
 gnu/packages/kde-utils.scm | 42 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 722a9aaaf3..907efc52d9 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -23,7 +23,8 @@
   #:use-module (guix packages)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kde-plasma)
-  #:use-module (gnu packages qt))
+  #:use-module (gnu packages qt)
+  #:use-module (gnu packages xorg))
 
 (define-public kate
   (package
@@ -122,3 +123,42 @@ as you would use a lens to magnify a newspaper fine-print or a photograph.
 This application is useful for a variety of people: from researchers to
 artists to web-designers to people with low vision.")
     (license (list license:gpl2+ license:fdl1.2+))))
+
+(define-public kmousetool
+  (package
+    (name "kmousetool")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/kmousetool-" version ".tar.xz"))
+       (sha256
+        (base32 "169kk20mkm29nycg2vs1k5cs22gzchqs9hbfd661cy2l7n4d8d04"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kconfigwidgets", kconfigwidgets)
+       ("kdbusaddons" ,kdbusaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("knotifications" ,knotifications)
+       ("kxmlgui" ,kxmlgui)
+       ("kwindowsystem" ,kwindowsystem)
+       ("libxtst" ,libxtst)
+       ("libxt" ,libxt)
+       ("phonon" ,phonon)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)))
+    (home-page "https://kde.org/applications/utilities/org.kde.kmousetool")
+    (synopsis "Automatic mouse click and mouse manipulation tool for the
+disabled")
+    (description "KMouseTool clicks the mouse whenever the mouse cursor pauses
+briefly.  It was designed to help those with repetitive strain injuries, for
+whom pressing buttons hurts.")
+    (license (list license:gpl2+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 06/12] gnu: Add kmouth.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (3 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 05/12] gnu: Add kmousetool Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 07/12] gnu: Add kronometer Hartmut Goebel
                     ` (6 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (kmouth): New variable.
---
 gnu/packages/kde-utils.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 907efc52d9..ed2312e48f 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -162,3 +162,43 @@ disabled")
 briefly.  It was designed to help those with repetitive strain injuries, for
 whom pressing buttons hurts.")
     (license (list license:gpl2+ license:fdl1.2+))))
+
+(define-public kmouth
+  (package
+    (name "kmouth")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/kmouth-" version ".tar.xz"))
+       (sha256
+        (base32 "1agjxf1jfi967hj1iz788n6cna6fr7qg80zsx6s119hg7b0xwqmr"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kcompletion" ,kcompletion)
+       ("kconfig", kconfig)
+       ("kconfigwidgets", kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("ki18n" ,ki18n)
+       ("kio" ,kio)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)
+       ("qtspeech" ,qtspeech)))
+    (home-page "https://kde.org/applications/utilities/org.kde.kmouth")
+    (synopsis "Type-and-say frontend for speech synthesizers")
+    (description "KMouth is a program which enables persons that cannot speak
+to let their computer speak, e.g. mutal people or people who have lost their
+voice.  It has a text input field and speaks the sentences that you enter.  It
+also has support for user defined phrasebooks.
+
+It includes a history of spoken sentences from which the user can select
+sentences to be re-spoken.")
+    (license (list license:gpl2+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 07/12] gnu: Add kronometer.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (4 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 06/12] gnu: Add kmouth Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 08/12] gnu: Add krusader Hartmut Goebel
                     ` (5 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (kronometer): New variable.
---
 gnu/packages/kde-utils.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index ed2312e48f..927bfc2351 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -202,3 +202,45 @@ also has support for user defined phrasebooks.
 It includes a history of spoken sentences from which the user can select
 sentences to be re-spoken.")
     (license (list license:gpl2+ license:fdl1.2+))))
+
+(define-public kronometer
+  (package
+    (name "kronometer")
+    (version "2.2.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/kronometer/" version
+                           "/src/kronometer-" version ".tar.xz"))
+       (sha256
+        (base32 "05hs8729a3aqjpwmn2xdf2sriacrll4sj4ax3lm4s1ravj09n9bm"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets", kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("ki18n" ,ki18n)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases (@ (guix build qt-build-system) %standard-phases)
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://kde.org/applications/utilities/org.kde.kronometer")
+    (synopsis "Simple stopwatch application")
+    (description "Kronometer is a stopwatch application.  It features the
+basic stopwatch actions (pause, resume, reset, laps), as well as the ability
+to save the times and resume them later.")
+    (license license:gpl2+)))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 08/12] gnu: Add krusader.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (5 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 07/12] gnu: Add kronometer Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 09/12] gnu: Add okteta Hartmut Goebel
                     ` (4 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (krusader): New variable.
---
 gnu/packages/kde-utils.scm | 57 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 927bfc2351..a96b0a29e9 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -21,6 +21,7 @@
   #:use-module (guix download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kde-plasma)
   #:use-module (gnu packages qt)
@@ -244,3 +245,59 @@ sentences to be re-spoken.")
 basic stopwatch actions (pause, resume, reset, laps), as well as the ability
 to save the times and resume them later.")
     (license license:gpl2+)))
+
+(define-public krusader
+  (package
+    (name "krusader")
+    (version "2.7.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/krusader/" version
+                           "/krusader-" version ".tar.xz"))
+       (sha256
+        (base32 "02b1jz5a7cjr13v6c7fczrhs1xmg1krnva5fxk8x2bf4nd1rm8s1"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("karchive" ,karchive)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("knotifications" ,knotifications)
+       ("kparts" ,kparts)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwallet" ,kwallet)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)
+       ("zlib" ,zlib)))
+    (home-page "https://www.krusader.org")
+    (synopsis "Twin-panel (commander-style) file manager")
+    (description "Krusader is a simple, easy, yet powerful,
+twin-panel (commander-style) file manager, similar to Midnight Commander or
+Total Commander
+
+It provides all the file management features you could possibly want.  Plus:
+extensive archive handling, mounted filesystem support, FTP, advanced search
+module, an internal viewer/editor, directory synchronisation, file content
+comparisons, powerful batch renaming and much much more.  It supports a wide
+variety of archive formats and can handle other KIO slaves such as smb or
+fish.
+
+Almost completely customizable, Krusader is very user friendly, fast and looks
+great on your desktop.")
+    (license license:gpl2+)))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 09/12] gnu: Add okteta.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (6 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 08/12] gnu: Add krusader Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 10/12] gnu: Add rsibreak Hartmut Goebel
                     ` (3 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (okteta): New variable.
---
 gnu/packages/kde-utils.scm | 65 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index a96b0a29e9..2aac8e5c11 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -22,6 +22,8 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages kde)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kde-plasma)
   #:use-module (gnu packages qt)
@@ -301,3 +303,66 @@ fish.
 Almost completely customizable, Krusader is very user friendly, fast and looks
 great on your desktop.")
     (license license:gpl2+)))
+
+(define-public okteta
+  (package
+    (name "okteta")
+    (version "17.12.3")
+    (source
+     (origin
+       (method url-fetch)
+       ;; TODO: Why is this not in "stable" anymore
+       (uri (string-append "mirror://kde/Attic/applications/" version
+                           "/src/okteta-" version ".tar.xz"))
+       (sha256
+        (base32 "03wsv83l1cay2dpcsksad124wzan7kh8zxdw1h0yicn398kdbck4"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("kbookmarks" ,kbookmarks)
+       ("kcmutils" ,kcmutils)
+       ("kcodecs" ,kcodecs)
+       ("kcrash" ,kcrash)
+       ("kcompletion" ,kcompletion)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kdbusaddons" ,kdbusaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("knewstuff" ,knewstuff)
+       ("kparts" ,kparts)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qca" ,qca)
+       ("qtbase" ,qtbase)
+       ("qtscript" ,qtscript)
+       ("shared-mime-info" ,shared-mime-info)))
+    (arguments
+     `(#:phases
+       (modify-phases (@ (guix build qt-build-system) %standard-phases)
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             (setenv "HOME" "/tmp/dummy-home")
+             #t)))))
+    (home-page "https://kde.org/applications/utilities/org.kde.okteta")
+    (synopsis "Hexadecimal editor for binary files")
+    (description "Okteta is a simple editor for the raw data of files.  This
+type of program is also called hex editor or binary editor.
+
+The data is displayed in the traditional view with two columns: one with the
+numeric values and one with the assigned characters.  Editing can be done both
+in the value column and the character column.  Besides the usual editing
+capabilities Okteta also brings a small set of tools, like a table listing
+decodings into common simple data types, a table listing all possible bytes
+with its character and value equivalents, a info view with a statistic and a
+filter tool.  All modifications to the data loaded can be endlessly undone or
+redone.")
+    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 10/12] gnu: Add rsibreak.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (7 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 09/12] gnu: Add okteta Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 11/12] gnu: Add smb4k Hartmut Goebel
                     ` (2 subsequent siblings)
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (rsibreak): New variable.
---
 gnu/packages/kde-utils.scm | 49 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 2aac8e5c11..7e76d4b38b 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -366,3 +366,52 @@ with its character and value equivalents, a info view with a statistic and a
 filter tool.  All modifications to the data loaded can be endlessly undone or
 redone.")
     (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
+
+(define-public rsibreak
+  (package
+    (name "rsibreak")
+    (version "0.12.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde//stable/rsibreak/0.12/"
+                           "rsibreak-" version ".tar.xz"))
+       (sha256
+        (base32 "09axg6gbmpnxsk88mdjbxxvfaj5af7xaf1gmnr17b0506zcfgwhv"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kidletime" ,kidletime)
+       ("knotifications" ,knotifications)
+       ("knotifyconfig" ,knotifyconfig)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases (@ (guix build qt-build-system) %standard-phases)
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://kde.org/applications/utilities/org.kde.rsibreak")
+    (synopsis "Assists in the Recovery and Prevention of Repetitive Strain
+Injury")
+    (description "Repetitive Strain Injury is an illness which can occur as a
+result of working with a mouse and keyboard.  This utility can be used to
+remind you to take a break now and then.")
+    (license (list license:gpl2+ license:fdl1.2+))))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 11/12] gnu: Add smb4k.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (8 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 10/12] gnu: Add rsibreak Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-09 21:53   ` [bug#38553] [PATCH 12/12] gnu: Add sweeper Hartmut Goebel
  2019-12-19 22:20   ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Ludovic Courtès
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (smb4k): New variable.
---
 gnu/packages/kde-utils.scm | 74 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 7e76d4b38b..5ebfb07be5 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -27,6 +27,7 @@
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kde-plasma)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages samba)
   #:use-module (gnu packages xorg))
 
 (define-public kate
@@ -415,3 +416,76 @@ Injury")
 result of working with a mouse and keyboard.  This utility can be used to
 remind you to take a break now and then.")
     (license (list license:gpl2+ license:fdl1.2+))))
+
+(define-public smb4k
+  (package
+    (name "smb4k")
+    (version "3.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://sourceforge.net/projects/smb4k/files/"
+                           version "/smb4k-" version ".tar.xz/download"))
+       (sha256
+        (base32 "1daajaj8qhxkzz8dsaracwi49z4i57466h6qnqnh2ir2l54q00ir"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcompletion" ,kcompletion)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kjobwidgets" ,kjobwidgets)
+       ("knotifications" ,knotifications)
+       ("knotifyconfig" ,knotifyconfig)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwallet" ,kwallet)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("libsmbclient" ,samba)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("plasma-framework" ,plasma-framework)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("solid" ,solid)))
+    (home-page "https://kde.org/applications/utilities/org.kde.smb4k")
+    (synopsis "Samba (SMB) share advanced browser")
+    (description "Smb4K is an network neighborhood browser for the KDE
+Software Compilation and a frontend to the programs of the Samba software
+suite.
+
+Features:
+@itemize
+@item Scanning for (active) workgroups, hosts, and shares
+@item Support of the CIFS (Linux) and SMBFS (FreeBSD) file system
+@item Mounting and unmounting of shares (using the KAuth framework)
+@item Access to the files of a mounted share using a file manager or terminal
+@item Auto-detection of external mounts and unmounts
+@item Remounting of previously used shares on program start
+@item Miscellaneous infos about remote network items and mounted shares
+@item Network search
+@item WINS server support
+@item Preview of the contents of a share
+@item Several methods to look up the initial list of workgroups and domains
+@item Default login
+@item Special handling of homes shares
+@item Ability to bookmark favorite shares and organize them in groups
+@item System tray widget
+@item Support of advanced Samba options
+@item Support of printer shares
+@item KWallet support
+@item Synchronization of a remote share with a local copy and vice versa
+@item Ability to define custom options for individual servers and shares
+@item Laptop support through the Solid hardware device framework
+@end itemize")
+    (license license:gpl2+)))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 12/12] gnu: Add sweeper.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (9 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 11/12] gnu: Add smb4k Hartmut Goebel
@ 2019-12-09 21:53   ` Hartmut Goebel
  2019-12-19 22:20   ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Ludovic Courtès
  11 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-09 21:53 UTC (permalink / raw)
  To: 38553

* gnu/packages/kde-utils.scm (sweeper): New variable.
---
 gnu/packages/kde-utils.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 5ebfb07be5..2ea5e7c505 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -489,3 +489,42 @@ Features:
 @item Laptop support through the Solid hardware device framework
 @end itemize")
     (license license:gpl2+)))
+
+(define-public sweeper
+  (package
+    (name "sweeper")
+    (version "19.08.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/applications/" version
+                           "/src/sweeper-" version ".tar.xz"))
+       (sha256
+        (base32 "1gn87yxmhi7rs82jq7y89bvlx33xbl9wq8kr96pcz423khqvjl84"))))
+    (properties `((tags . ("Desktop" "KDE" "Utilities"))))
+    (build-system qt-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kactivities-stats" ,kactivities-stats)
+       ("kbookmarks" ,kbookmarks)
+       ("kcrash" ,kcrash)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("ki18n" ,ki18n)
+       ("kio" ,kio)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kxmlgui" ,kxmlgui)
+       ("oxygen-icons" ,oxygen-icons) ;; default icon set
+       ("qtbase" ,qtbase)))
+    (home-page "https://kde.org/applications/utilities/org.kde.sweeper")
+    (synopsis "Temporary file and history cleaner")
+    (description "
+Sweeper helps to clean unwanted traces the user leaves on the system and to
+regain disk space removing unused temporary files.
+It can quickly remove temporary information, such as web page cookies,
+browser history, or the list of recently-opened documents.  It helps provide
+additional privacy on a system shared between multiple users.")
+    (license license:lgpl2.0+ )))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
                     ` (10 preceding siblings ...)
  2019-12-09 21:53   ` [bug#38553] [PATCH 12/12] gnu: Add sweeper Hartmut Goebel
@ 2019-12-19 22:20   ` Ludovic Courtès
  2019-12-21 19:19     ` Hartmut Goebel
  11 siblings, 1 reply; 19+ messages in thread
From: Ludovic Courtès @ 2019-12-19 22:20 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 38553

Hi!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/kde.scm (grantleetheme): New variable.

[...]

> +    (properties `((tags . ("Desktop" "KDE" "Themes"))))

Please remove this line since it’s not handled by tools and not agreed
upon.

> +       (modify-phases (@ (guix build qt-build-system) %standard-phases)
                          ^
As a rule of thumb, we should avoid using ‘@’ and ‘@@’.  So here, I’d
suggest writing

  #:modules ((guix build qt-build-system) …)

to make sure that module is in scope.

> +    (home-page "https://cgit.kde.org/grantleetheme.git")
> +    (synopsis "Library providing grantlee theme support")
> +    (description "This library provides grantlee theme support.")

Please capitalize “Grantlee” if it’s a proper noun, and ideally expound
a bit.

> +    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))

Could you add a comment explaining whether this is triple-license or
something else?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-19 22:20   ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Ludovic Courtès
@ 2019-12-21 19:19     ` Hartmut Goebel
  2019-12-21 23:13       ` Ludovic Courtès
  0 siblings, 1 reply; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-21 19:19 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 38553

Hi Ludo,

Am 19.12.19 um 23:20 schrieb Ludovic Courtès:
>> +    (properties `((tags . ("Desktop" "KDE" "Themes"))))
> Please remove this line since it’s not handled by tools and not agreed
> upon.

ACK. I will remove this for all other packages and all other pending
patches, too.


>> +       (modify-phases (@ (guix build qt-build-system) %standard-phases)
>                           ^
> As a rule of thumb, we should avoid using ‘@’ and ‘@@’.  So here, I’d
> suggest writing
>
>   #:modules ((guix build qt-build-system) …)
>
> to make sure that module is in scope.

AFAIU the module already is in scope, since it is part of
%qt-build-system-modules. What I intend here is to address
"%standard-phases" as defined in (guix build qt-build-system).

I agree me code is not nice. Maybe we should rename "%standard-phases"
in (guix build qt-build-system) into e.g. "%qt-standard-phases". WDYT?


>> +    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
> Could you add a comment explaining whether this is triple-license or
> something else?

This seems to be common to many KDE packages including programs, libs
and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course
I can add a respective comment, which most of the packages would get. Is
this your intention?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-21 19:19     ` Hartmut Goebel
@ 2019-12-21 23:13       ` Ludovic Courtès
  2019-12-22 21:46         ` Hartmut Goebel
  0 siblings, 1 reply; 19+ messages in thread
From: Ludovic Courtès @ 2019-12-21 23:13 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 38553

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Hi,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

>>> +       (modify-phases (@ (guix build qt-build-system) %standard-phases)
>>                           ^
>> As a rule of thumb, we should avoid using ‘@’ and ‘@@’.  So here, I’d
>> suggest writing
>>
>>   #:modules ((guix build qt-build-system) …)
>>
>> to make sure that module is in scope.
>
> AFAIU the module already is in scope, since it is part of
> %qt-build-system-modules. What I intend here is to address
> "%standard-phases" as defined in (guix build qt-build-system).

Actually, unless I’m mistaken, (guix build qt-build-system) is not in
scope by default.  To fix it, we need:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1304 bytes --]

diff --git a/guix/build-system/qt.scm b/guix/build-system/qt.scm
index b776845377..e2f277d3ca 100644
--- a/guix/build-system/qt.scm
+++ b/guix/build-system/qt.scm
@@ -126,7 +126,7 @@
                       (qt-wrap-excluded-outputs ''())
                       (system (%current-system))
                       (imported-modules %qt-build-system-modules)
-                      (modules '((guix build cmake-build-system)
+                      (modules '((guix build qt-build-system)
                                  (guix build utils))))
   "Build SOURCE using CMAKE, and with INPUTS. This assumes that SOURCE
 provides a 'CMakeLists.txt' file as its build system."
@@ -208,7 +208,7 @@ provides a 'CMakeLists.txt' file as its build system."
                             (system (%current-system))
                             (build (nix-system->gnu-triplet system))
                             (imported-modules %qt-build-system-modules)
-                            (modules '((guix build cmake-build-system)
+                            (modules '((guix build qt-build-system)
                                        (guix build utils))))
   "Cross-build NAME using CMAKE for TARGET, where TARGET is a GNU triplet and
 with INPUTS.  This assumes that SOURCE provides a 'CMakeLists.txt' file as its

[-- Attachment #3: Type: text/plain, Size: 639 bytes --]


Does that make sense?

With this change in place, no need for ‘@’!  :-)

>>> +    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
>> Could you add a comment explaining whether this is triple-license or
>> something else?
>
> This seems to be common to many KDE packages including programs, libs
> and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course
> I can add a respective comment, which most of the packages would get. Is
> this your intention?

Oh I see.  Yes, that was my intention, but I guess you could make a
super-concise one-line summary of that.

Thanks!

Ludo’.

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-21 23:13       ` Ludovic Courtès
@ 2019-12-22 21:46         ` Hartmut Goebel
  2019-12-23 16:55           ` Ludovic Courtès
  0 siblings, 1 reply; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-22 21:46 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 38553

Hi,

Am 22.12.19 um 00:13 schrieb Ludovic Courtès:

> Actually, unless I’m mistaken, (guix build qt-build-system) is not in
> scope by default.  To fix it, we need:

Oh, seems like a bug in qt-build.system. Many thanks for spotting this.
I just submitted a patch for this (ubs, I missed "Coauthored-by Ludo",
will add immediately), see
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38711


>> This seems to be common to many KDE packages including programs, libs
>> and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course
>> I can add a respective comment, which most of the packages would get. Is
>> this your intention?
> Oh I see.  Yes, that was my intention, but I guess you could make a
> super-concise one-line summary of that.
WDYT about this format? I would then apply this to all KDE packages in
my pipeline.

    (license ;; GPL for programs, LGPL for libraries, FDL for documentation
     (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-22 21:46         ` Hartmut Goebel
@ 2019-12-23 16:55           ` Ludovic Courtès
  2019-12-23 17:28             ` bug#38553: " Hartmut Goebel
  0 siblings, 1 reply; 19+ messages in thread
From: Ludovic Courtès @ 2019-12-23 16:55 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 38553

Hi,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 22.12.19 um 00:13 schrieb Ludovic Courtès:

[...]

>>> This seems to be common to many KDE packages including programs, libs
>>> and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course
>>> I can add a respective comment, which most of the packages would get. Is
>>> this your intention?
>> Oh I see.  Yes, that was my intention, but I guess you could make a
>> super-concise one-line summary of that.
> WDYT about this format? I would then apply this to all KDE packages in
> my pipeline.
>
>     (license ;; GPL for programs, LGPL for libraries, FDL for documentation
>      (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))

Perfect!

Ludo’.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#38553: [PATCH 01/12] gnu: Add grantleetheme.
  2019-12-23 16:55           ` Ludovic Courtès
@ 2019-12-23 17:28             ` Hartmut Goebel
  0 siblings, 0 replies; 19+ messages in thread
From: Hartmut Goebel @ 2019-12-23 17:28 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 38553-close

Pushed the serie as 17a1566f76403dcc0154782f5fc27db1be54dba6

thanks for the detailed review,

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2019-12-23 17:30 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 21:52 [bug#38553] [PATCH 00/12] Add two KDE packages and 10 KDE utils Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 03/12] gnu: Add kate Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 04/12] gnu: Add kmag Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 05/12] gnu: Add kmousetool Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 06/12] gnu: Add kmouth Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 07/12] gnu: Add kronometer Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 08/12] gnu: Add krusader Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 09/12] gnu: Add okteta Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 10/12] gnu: Add rsibreak Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 11/12] gnu: Add smb4k Hartmut Goebel
2019-12-09 21:53   ` [bug#38553] [PATCH 12/12] gnu: Add sweeper Hartmut Goebel
2019-12-19 22:20   ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Ludovic Courtès
2019-12-21 19:19     ` Hartmut Goebel
2019-12-21 23:13       ` Ludovic Courtès
2019-12-22 21:46         ` Hartmut Goebel
2019-12-23 16:55           ` Ludovic Courtès
2019-12-23 17:28             ` bug#38553: " Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).