From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51652) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iikIG-0005pr-7a for guix-patches@gnu.org; Sat, 21 Dec 2019 14:20:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iikIF-0003A2-10 for guix-patches@gnu.org; Sat, 21 Dec 2019 14:20:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iikIE-00037J-NM for guix-patches@gnu.org; Sat, 21 Dec 2019 14:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iikIE-00021M-DW for guix-patches@gnu.org; Sat, 21 Dec 2019 14:20:02 -0500 Subject: [bug#38553] [PATCH 01/12] gnu: Add grantleetheme. Resent-Message-ID: References: <20191209215219.24247-1-h.goebel@crazy-compilers.com> <20191209215358.24449-1-h.goebel@crazy-compilers.com> <87immckle4.fsf@gnu.org> From: Hartmut Goebel Message-ID: <176afb50-286a-6b0b-b6cb-25090adc4630@crazy-compilers.com> Date: Sat, 21 Dec 2019 20:19:36 +0100 MIME-Version: 1.0 In-Reply-To: <87immckle4.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38553@debbugs.gnu.org Hi Ludo, Am 19.12.19 um 23:20 schrieb Ludovic Courtès: >> + (properties `((tags . ("Desktop" "KDE" "Themes")))) > Please remove this line since it’s not handled by tools and not agreed > upon. ACK. I will remove this for all other packages and all other pending patches, too. >> + (modify-phases (@ (guix build qt-build-system) %standard-phases) > ^ > As a rule of thumb, we should avoid using ‘@’ and ‘@@’. So here, I’d > suggest writing > > #:modules ((guix build qt-build-system) …) > > to make sure that module is in scope. AFAIU the module already is in scope, since it is part of %qt-build-system-modules. What I intend here is to address "%standard-phases" as defined in (guix build qt-build-system). I agree me code is not nice. Maybe we should rename "%standard-phases" in (guix build qt-build-system) into e.g. "%qt-standard-phases". WDYT? >> + (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+)))) > Could you add a comment explaining whether this is triple-license or > something else? This seems to be common to many KDE packages including programs, libs and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course I can add a respective comment, which most of the packages would get. Is this your intention? -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |