From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 38553@debbugs.gnu.org
Subject: [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
Date: Sat, 21 Dec 2019 20:19:36 +0100 [thread overview]
Message-ID: <176afb50-286a-6b0b-b6cb-25090adc4630@crazy-compilers.com> (raw)
In-Reply-To: <87immckle4.fsf@gnu.org>
Hi Ludo,
Am 19.12.19 um 23:20 schrieb Ludovic Courtès:
>> + (properties `((tags . ("Desktop" "KDE" "Themes"))))
> Please remove this line since it’s not handled by tools and not agreed
> upon.
ACK. I will remove this for all other packages and all other pending
patches, too.
>> + (modify-phases (@ (guix build qt-build-system) %standard-phases)
> ^
> As a rule of thumb, we should avoid using ‘@’ and ‘@@’. So here, I’d
> suggest writing
>
> #:modules ((guix build qt-build-system) …)
>
> to make sure that module is in scope.
AFAIU the module already is in scope, since it is part of
%qt-build-system-modules. What I intend here is to address
"%standard-phases" as defined in (guix build qt-build-system).
I agree me code is not nice. Maybe we should rename "%standard-phases"
in (guix build qt-build-system) into e.g. "%qt-standard-phases". WDYT?
>> + (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
> Could you add a comment explaining whether this is triple-license or
> something else?
This seems to be common to many KDE packages including programs, libs
and docs. Programs have GPL, libs have LGPL and docs have FDL. Of course
I can add a respective comment, which most of the packages would get. Is
this your intention?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2019-12-21 19:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:52 [bug#38553] [PATCH 00/12] Add two KDE packages and 10 KDE utils Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 03/12] gnu: Add kate Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 04/12] gnu: Add kmag Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 05/12] gnu: Add kmousetool Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 06/12] gnu: Add kmouth Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 07/12] gnu: Add kronometer Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 08/12] gnu: Add krusader Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 09/12] gnu: Add okteta Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 10/12] gnu: Add rsibreak Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 11/12] gnu: Add smb4k Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 12/12] gnu: Add sweeper Hartmut Goebel
2019-12-19 22:20 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Ludovic Courtès
2019-12-21 19:19 ` Hartmut Goebel [this message]
2019-12-21 23:13 ` Ludovic Courtès
2019-12-22 21:46 ` Hartmut Goebel
2019-12-23 16:55 ` Ludovic Courtès
2019-12-23 17:28 ` bug#38553: " Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176afb50-286a-6b0b-b6cb-25090adc4630@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=38553@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).