From: "Ludovic Courtès" <ludo@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 38553@debbugs.gnu.org
Subject: [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
Date: Thu, 19 Dec 2019 23:20:35 +0100 [thread overview]
Message-ID: <87immckle4.fsf@gnu.org> (raw)
In-Reply-To: <20191209215358.24449-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 9 Dec 2019 22:53:47 +0100")
Hi!
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * gnu/packages/kde.scm (grantleetheme): New variable.
[...]
> + (properties `((tags . ("Desktop" "KDE" "Themes"))))
Please remove this line since it’s not handled by tools and not agreed
upon.
> + (modify-phases (@ (guix build qt-build-system) %standard-phases)
^
As a rule of thumb, we should avoid using ‘@’ and ‘@@’. So here, I’d
suggest writing
#:modules ((guix build qt-build-system) …)
to make sure that module is in scope.
> + (home-page "https://cgit.kde.org/grantleetheme.git")
> + (synopsis "Library providing grantlee theme support")
> + (description "This library provides grantlee theme support.")
Please capitalize “Grantlee” if it’s a proper noun, and ideally expound
a bit.
> + (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))
Could you add a comment explaining whether this is triple-license or
something else?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-12-19 22:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:52 [bug#38553] [PATCH 00/12] Add two KDE packages and 10 KDE utils Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 02/12] gnu: Add zeroconf-ioslave Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 03/12] gnu: Add kate Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 04/12] gnu: Add kmag Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 05/12] gnu: Add kmousetool Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 06/12] gnu: Add kmouth Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 07/12] gnu: Add kronometer Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 08/12] gnu: Add krusader Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 09/12] gnu: Add okteta Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 10/12] gnu: Add rsibreak Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 11/12] gnu: Add smb4k Hartmut Goebel
2019-12-09 21:53 ` [bug#38553] [PATCH 12/12] gnu: Add sweeper Hartmut Goebel
2019-12-19 22:20 ` Ludovic Courtès [this message]
2019-12-21 19:19 ` [bug#38553] [PATCH 01/12] gnu: Add grantleetheme Hartmut Goebel
2019-12-21 23:13 ` Ludovic Courtès
2019-12-22 21:46 ` Hartmut Goebel
2019-12-23 16:55 ` Ludovic Courtès
2019-12-23 17:28 ` bug#38553: " Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87immckle4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38553@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).