From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47630)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii4AL-00078i-JS
 for guix-patches@gnu.org; Thu, 19 Dec 2019 17:21:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii4AK-0007XE-9U
 for guix-patches@gnu.org; Thu, 19 Dec 2019 17:21:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39685)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ii4AI-0007Un-Q7
 for guix-patches@gnu.org; Thu, 19 Dec 2019 17:21:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii4AI-0005lN-Mg
 for guix-patches@gnu.org; Thu, 19 Dec 2019 17:21:02 -0500
Subject: [bug#38553] [PATCH 01/12] gnu: Add grantleetheme.
Resent-Message-ID: <handler.38553.B38553.157679404722064@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191209215219.24247-1-h.goebel@crazy-compilers.com>
 <20191209215358.24449-1-h.goebel@crazy-compilers.com>
Date: Thu, 19 Dec 2019 23:20:35 +0100
In-Reply-To: <20191209215358.24449-1-h.goebel@crazy-compilers.com> (Hartmut
 Goebel's message of "Mon, 9 Dec 2019 22:53:47 +0100")
Message-ID: <87immckle4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 38553@debbugs.gnu.org

Hi!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/kde.scm (grantleetheme): New variable.

[...]

> +    (properties `((tags . ("Desktop" "KDE" "Themes"))))

Please remove this line since it=E2=80=99s not handled by tools and not agr=
eed
upon.

> +       (modify-phases (@ (guix build qt-build-system) %standard-phases)
                          ^
As a rule of thumb, we should avoid using =E2=80=98@=E2=80=99 and =E2=80=98=
@@=E2=80=99.  So here, I=E2=80=99d
suggest writing

  #:modules ((guix build qt-build-system) =E2=80=A6)

to make sure that module is in scope.

> +    (home-page "https://cgit.kde.org/grantleetheme.git")
> +    (synopsis "Library providing grantlee theme support")
> +    (description "This library provides grantlee theme support.")

Please capitalize =E2=80=9CGrantlee=E2=80=9D if it=E2=80=99s a proper noun,=
 and ideally expound
a bit.

> +    (license (list license:gpl2+ license:lgpl2.0+ license:fdl1.2+))))

Could you add a comment explaining whether this is triple-license or
something else?

Thanks,
Ludo=E2=80=99.