From: Maxime Devos <maximedevos@telenet.be>
To: Robby Zambito <contact@robbyzambito.me>, 50084@debbugs.gnu.org
Cc: paul@apatience.com
Subject: [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies.
Date: Thu, 19 Aug 2021 17:24:09 +0200 [thread overview]
Message-ID: <08627decd152bee69410912cf5ac139af47dcee7.camel@telenet.be> (raw)
In-Reply-To: <20210819020234.642522-1-contact@robbyzambito.me>
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
Robby Zambito schreef op wo 18-08-2021 om 22:02 [-0400]:
> * gnu/packages/xdisorg.scm (waypipe)[arguments]: Remove unused
> argument from fix-sleep-path phase.
> [native-inputs]: Add python, coreutils.
> [inputs]: Remove python, coreutils.
> ---
> Paul,
>
> Thank you for the tips. I've removed the unused outputs argument, as
> well as the out variable.
>
> I'm a bit confused as to why test dependencies are supposed to be
> native-inputs. Aren't the tests run on the target architecture, not the
> build machine architecture? And aren't native-inputs built for the build
> machine architecture?
By default, tests are never run when cross-compiling, so putting test
dependencies in 'native-inputs' works in practice. Theoretically,
putting test dependencies in 'inputs' might be cleaner, especially
if at some point Guix supports testing cross-compiled packages
(maybe the build directory could be copied to a "worktree" output or
something, and guix could provide a command to test the cross-compiled
binaries on the machine that was cross-compiled for or something).
Nevertheless, test dependencies tend to be put in 'native-input' anyways.
This has a practical reason (*): not all build systems support
cross-compilation. E.g., the build system 'meson', used by 'glib', doesn't
support cross-compilation on 'master' (it does on 'core-updates-frozen' though),
so packages that (indirectly) have 'glib' as 'input' cannot be an 'input'.
(*) not necessarily the reason people originally had in mind.
> I cross compiled the package for armhf-linux and aarch64-linux and it
> built and tested fine with the changes you suggested, but I also did the
Are you sure it tested? Unless qemu transparent emulation is enabled
(see ‘Transparent Emulation with QEMU’ in the manual) that cannot happen.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-08-19 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 1:53 [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-18 20:27 ` [bug#50084] [PATCH v2] gnu: waypipe: Enable tests Robby Zambito
2021-08-19 2:02 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-19 4:04 ` Paul A. Patience
2021-08-19 15:24 ` Maxime Devos [this message]
2021-08-19 19:58 ` Robby Zambito
2021-08-19 21:13 ` Maxime Devos
2021-08-18 22:56 ` [bug#50084] [PATCH] gnu: Add waypipe Paul A. Patience
2021-08-19 22:11 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-30 1:54 ` [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-30 1:58 ` Robby Zambito
2021-09-06 9:15 ` bug#50084: " Nicolas Goaziou
2021-09-07 21:13 ` [bug#50084] " Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08627decd152bee69410912cf5ac139af47dcee7.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50084@debbugs.gnu.org \
--cc=contact@robbyzambito.me \
--cc=paul@apatience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).