From: Robby Zambito <contact@robbyzambito.me>
To: 50084@debbugs.gnu.org
Cc: paul@apatience.com, Robby Zambito <contact@robbyzambito.me>
Subject: [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies.
Date: Wed, 18 Aug 2021 22:02:35 -0400 [thread overview]
Message-ID: <20210819020234.642522-1-contact@robbyzambito.me> (raw)
In-Reply-To: <20210818202710.55244-1-contact@robbyzambito.me>
* gnu/packages/xdisorg.scm (waypipe)[arguments]: Remove unused
argument from fix-sleep-path phase.
[native-inputs]: Add python, coreutils.
[inputs]: Remove python, coreutils.
---
Paul,
Thank you for the tips. I've removed the unused outputs argument, as
well as the out variable.
I'm a bit confused as to why test dependencies are supposed to be
native-inputs. Aren't the tests run on the target architecture, not the
build machine architecture? And aren't native-inputs built for the build
machine architecture?
I cross compiled the package for armhf-linux and aarch64-linux and it
built and tested fine with the changes you suggested, but I also did the
same with how I had it previously.
Sincerely,
Robby
gnu/packages/xdisorg.scm | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index ba520d35ae..f5b041a590 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -885,19 +885,15 @@ include cursor in the resulting image.")
`(#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-sleep-path
- (lambda* (#:key inputs outputs #:allow-other-keys)
- (let ((out (assoc-ref outputs "out"))
- (coreutils (assoc-ref inputs "coreutils")))
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((coreutils (assoc-ref inputs "coreutils")))
(substitute* "./test/startup_failure.py"
- (("sleep")
- (string-append coreutils "/bin/sleep")))
- #t))))))
+ (("sleep") (string-append coreutils "/bin/sleep")))))))))
(native-inputs
`(("pkg-config" ,pkg-config)
- ("scdoc" ,scdoc)))
- (inputs
- ;; For tests
- `(("python" ,python)
+ ("scdoc" ,scdoc)
+ ;; For tests
+ ("python" ,python)
("coreutils" ,coreutils)))
(home-page "https://gitlab.freedesktop.org/mstoeckl/waypipe")
(synopsis "Proxy for Wayland protocol applications")
--
2.32.0
next prev parent reply other threads:[~2021-08-19 2:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 1:53 [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-18 20:27 ` [bug#50084] [PATCH v2] gnu: waypipe: Enable tests Robby Zambito
2021-08-19 2:02 ` Robby Zambito [this message]
2021-08-19 4:04 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Paul A. Patience
2021-08-19 15:24 ` Maxime Devos
2021-08-19 19:58 ` Robby Zambito
2021-08-19 21:13 ` Maxime Devos
2021-08-18 22:56 ` [bug#50084] [PATCH] gnu: Add waypipe Paul A. Patience
2021-08-19 22:11 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-30 1:54 ` [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-30 1:58 ` Robby Zambito
2021-09-06 9:15 ` bug#50084: " Nicolas Goaziou
2021-09-07 21:13 ` [bug#50084] " Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819020234.642522-1-contact@robbyzambito.me \
--to=contact@robbyzambito.me \
--cc=50084@debbugs.gnu.org \
--cc=paul@apatience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).